GNOME Bugzilla – Bug 745582
Improve giflib check in configure
Last modified: 2015-03-07 00:07:14 UTC
When linking with libgif, it is sometimes necessary to link with libX11. AC_CHECK_LIB has an argument that allows adding in dependent libraries, and using this works for me on Fedora (when building packages with hardened flags enabled, which will be the default for F23 and above).
Created attachment 298501 [details] [review] proposed patch
Comment on attachment 298501 [details] [review] proposed patch Hi there, thanks for the patch. Looking at the library's shared library deps, I don't see X11 though? Has this changed? $ ldd /usr/lib/i386-linux-gnu/libgif.so.4.1.6 linux-gate.so.1 => (0xf77ae000) libc.so.6 => /lib/i386-linux-gnu/libc.so.6 (0xf75c4000) /lib/ld-linux.so.2 (0xf77b1000) My main concern is adding a dependency that is not necessary and to fix another bug that we're possibly seeing? Not sure what you meant with hardened flags too?
Review of attachment 298501 [details] [review]: On Fedora Rawhide, libgif depends on libX11: david@lenovodave ~/checkout/gnome/tracker $ ldd /usr/lib64/libgif.so.4.1.6 linux-vdso.so.1 (0x00007ffddc7fe000) libSM.so.6 => /lib64/libSM.so.6 (0x00007f00d9867000) libICE.so.6 => /lib64/libICE.so.6 (0x00007f00d964a000) libX11.so.6 => /lib64/libX11.so.6 (0x00007f00d9308000) libc.so.6 => /lib64/libc.so.6 (0x00007f00d8f3e000) libuuid.so.1 => /lib64/libuuid.so.1 (0x00007f00d8d39000) libxcb.so.1 => /lib64/libxcb.so.1 (0x00007f00d8b16000) libdl.so.2 => /lib64/libdl.so.2 (0x00007f00d8912000) /lib64/ld-linux-x86-64.so.2 (0x00007f00d9c98000) libXau.so.6 => /lib64/libXau.so.6 (0x00007f00d870e000) Anyway, the linking problem seems to have disappeared with the more recent tracker build in Rawhide (where hardening is enabled, as described at https://fedoraproject.org/wiki/Changes/Harden_all_packages_with_position-independent_code), and the patch does not seem to be needed.