GNOME Bugzilla – Bug 745503
Kick a lot of telepathy functionality back to empathy
Last modified: 2015-03-03 22:33:41 UTC
In the early 3.2 days when this features were added, the idea was that empathy would be for the most part optional or invisible, and chat integration was a prominent part of the shell. These days on the other hand we want chat to be an application feature, and in particular it is not possible to be online unless a full fledged chat application is launched or set to autostart, which means that most of this code is unnecessary, and even dangerous in days where the shell is the trusted display server whose crash kills the session. Additionally, with the new message tray rework most of these features are broken because they rely on having actions in summary mode. What this patchset breaks is the ability to have working calls, file transfers and group chats by using 'mc-tool request' or 'mc-tool auto-connect' from the command line. I don't think it is a significant regression: it is just as easy to configure empathy to autostart as a daemon in background (empathy -hn), in which case there will be code taking care of this.
Created attachment 298382 [details] [review] TelepathyClient: remove subscription request notifications The ones handled by empathy are just fine
Created attachment 298383 [details] [review] TelepathyClient: remove account status notifications These notifications are annoying for the most part: presence changes happen inside an app (empathy or polari), and that app should have in app notifications for errors, instead of spamming the global notifications.
Created attachment 298384 [details] [review] TelepathyClient: remove call and file transfer approval Let empathy deal with these.
Created attachment 298385 [details] [review] TelepathyClient: stop handling room invitations Let empathy deal with these
Created attachment 298386 [details] [review] ShellTpClient: remove unused code
Created attachment 298387 [details] [review] NotificationDaemon: stop filtering notifications from empathy Now that we don't have our own code for showing telepathy notifications, we don't need to filter out empathy's.
Review of attachment 298382 [details] [review]: In the other patches you remove stuff from shell-tp-client as it becomes unused, except here where you did a separate commit. Please squash the two, otherwise LGTM
Review of attachment 298383 [details] [review]: LGTM
Review of attachment 298384 [details] [review]: LGTM
Review of attachment 298385 [details] [review]: LGTM
Review of attachment 298386 [details] [review]: Should be squashed with the subscription request patch
Review of attachment 298387 [details] [review]: OK
Pushed with suggested change. Attachment 298382 [details] pushed as 38a2f26 - TelepathyClient: remove subscription request notifications Attachment 298383 [details] pushed as e01076a - TelepathyClient: remove account status notifications Attachment 298384 [details] pushed as fab25e1 - TelepathyClient: remove call and file transfer approval Attachment 298385 [details] pushed as 707cc9e - TelepathyClient: stop handling room invitations Attachment 298387 [details] pushed as 8eb236a - NotificationDaemon: stop filtering notifications from empathy