After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745303 - Wayland: Initial setup window is not maximised
Wayland: Initial setup window is not maximised
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2015-02-27 18:59 UTC by Vadim Rutkovsky
Modified: 2015-03-17 17:51 UTC
See Also:
GNOME target: 3.16
GNOME version: ---


Attachments
Screenshot (871.97 KB, image/png)
2015-02-27 18:59 UTC, Vadim Rutkovsky
  Details
a patch (2.25 KB, patch)
2015-02-27 23:18 UTC, Matthias Clasen
none Details | Review
wayland: Don't skip notifying about initial maximized size (2.67 KB, patch)
2015-03-17 01:47 UTC, Jonas Ådahl
none Details | Review

Description Vadim Rutkovsky 2015-02-27 18:59:53 UTC
Created attachment 298117 [details]
Screenshot

Continuous build 20150227.51: initial setup for new user is not maximised on wayland session
Comment 1 Matthias Clasen 2015-02-27 22:44:32 UTC
This is a bug in the wayland backend. It fails to apply initial states.
Comment 2 Matthias Clasen 2015-02-27 23:18:24 UTC
Created attachment 298145 [details] [review]
a patch

I tried this patch, but it doesn't quite work with mutter - the window gets maximized decorations (no rounded corners), but it doesn't have the right size. Dragging a bit on the titlebar makes it jump to the right size, but things clearly go somewhat wrong here.
Comment 3 Matthias Clasen 2015-02-27 23:24:30 UTC
Compare bug 710652
Comment 4 Matthias Clasen 2015-02-27 23:33:23 UTC
the fullscreening part of the patch works ok, though
Comment 5 Matthias Clasen 2015-02-27 23:49:24 UTC
both maximizing and fullscreening work ok with weston
Comment 6 Matthias Clasen 2015-02-27 23:54:54 UTC
mutter sends a configure event with width=height=0 and the new state, whereas weston sends the configure event with the new state and the dimensions of the output.
Comment 7 Matthias Clasen 2015-02-28 00:09:24 UTC
I'll apply the patch and move this back to mutter
Comment 8 Jonas Ådahl 2015-03-17 01:47:53 UTC
Created attachment 299561 [details] [review]
wayland: Don't skip notifying about initial maximized size

When a client wants to start initialized it my set the maximized state
before having attached any buffers. Before we'd not notify the client of
the new expected size if the previous size was 0x0 as it would normally
mean we'd resize to 1x1, but since this is not always the case, only
avoid notifying the client if the previous size was 0x0 and the result
is 1x1.
Comment 9 Ray Strode [halfline] 2015-03-17 17:51:24 UTC
Attachment 299561 [details] pushed as 7b79c44 - wayland: Don't skip notifying about initial maximized size