After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745174 - gst-play: support play rate change
gst-play: support play rate change
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 738943 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-02-25 17:56 UTC by Víctor Manuel Jáquez Leal
Modified: 2017-04-11 08:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gst-play: support play rate change (2.49 KB, patch)
2015-02-25 17:56 UTC, Víctor Manuel Jáquez Leal
committed Details | Review

Description Víctor Manuel Jáquez Leal 2015-02-25 17:56:16 UTC
It is fun to have this feature, also it is useful for testing decoders.
Comment 1 Víctor Manuel Jáquez Leal 2015-02-25 17:56:22 UTC
Created attachment 297912 [details] [review]
gst-play: support play rate change
Comment 2 Tim-Philipp Müller 2015-02-25 18:11:28 UTC
Also see bug #738943.
Comment 3 Tim-Philipp Müller 2015-02-25 18:13:01 UTC
Why 'd' for flipping the rate?
Comment 4 Víctor Manuel Jáquez Leal 2015-02-25 18:21:23 UTC
(In reply to Tim-Philipp Müller from comment #3)
> Why 'd' for flipping the rate?

for _direction :)

It looks almost like a dup, isn't it?
Comment 5 Tim-Philipp Müller 2015-02-25 18:31:54 UTC
Yes, but I prefer your patch.
Comment 6 Tim-Philipp Müller 2015-02-26 11:01:27 UTC
Pushed, thanks for the patch!

I've added some mods on top, hope you don't mind :)

commit b4c45935b7acd0a592b3005daa670f9a3b2702e4
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Thu Feb 26 10:57:56 2015 +0000

    gst-play: more fine-grained playback rate control
    
    Use smaller steps for lower rates to allow more
    fine-grained control. Handle jump across 0 properly
    from both sides (just flip direction where we would
    have gone down to 0 instead). Don't artificially
    limit rates to +/- 10x. Print new rate.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=745174

commit 0c8967348ff1d894f1ce20ec14f33b0f94e2228c
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Thu Feb 26 10:20:20 2015 +0000

    gst-play: stash current playback rate in app structure
    
    https://bugzilla.gnome.org/show_bug.cgi?id=745174

commit c243f386c93a40affd388d160da7d1b899640291
Author: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
Date:   Wed Feb 25 18:52:11 2015 +0100

    gst-play: support changing the playback rate in interactive mode
    
    It is fun to have this feature, also it is useful for testing decoders.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=745174
Comment 7 Tim-Philipp Müller 2015-02-26 11:02:09 UTC
Comment on attachment 297912 [details] [review]
gst-play: support play rate change

Committed with minor change to fix compiler warning (remove unused sink variable).
Comment 8 Tim-Philipp Müller 2015-02-26 11:04:01 UTC
*** Bug 738943 has been marked as a duplicate of this bug. ***