After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745094 - Cancelling of paused message does not work reliably
Cancelling of paused message does not work reliably
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: HTTP Transport
2.48.x
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2015-02-24 15:32 UTC by Henry Hoegelow
Modified: 2015-02-27 17:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for showing and fixing the described behaviour (1.25 KB, patch)
2015-02-24 15:32 UTC, Henry Hoegelow 		none Details | Review
add a test for cancelling a paused message (1.81 KB, patch)
2015-02-25 09:24 UTC, Sven Neumann 		none Details | Review
fix cancellation of paused messages (1.12 KB, patch)
2015-02-25 09:25 UTC, Sven Neumann 		none Details | Review

Description Henry Hoegelow 2015-02-24 15:32:56 UTC 
Created attachment 297777 [details] [review]
patch for showing and fixing the described behaviour

SoupSession does not always cancel messages properly when the message is in paused state.

The attached patch adds a test case showing the behaviour in tests/session-test.c and the fix for it on soup-session.c.
Comment 1 Sven Neumann 2015-02-25 09:24:00 UTC 
Created attachment 297857 [details] [review]
add a test for cancelling a paused message
Comment 2 Sven Neumann 2015-02-25 09:25:55 UTC 
Created attachment 297858 [details] [review]
fix cancellation of paused messages

Here are two more patches. The first adds a test case for the described problem. The second fixes the problem in a sligthly different way than the change proposed by Henry. It basically does the same but avoids doing the queue lookup twice.
Comment 3 Dan Winship 2015-02-27 17:10:36 UTC 
fixed in git (and next week's release). Thanks for the patches.