After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745080 - Put markup directly in the string
Put markup directly in the string
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-02-24 11:23 UTC by Alexandre Franke
Modified: 2015-02-25 18:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Put markup directly in the string (1.35 KB, patch)
2015-02-24 11:38 UTC, Alexandre Franke 		none Details | Review
Put markup directly in the string (1.40 KB, patch)
2015-02-24 12:36 UTC, Alexandre Franke 		needs-work Details | Review
Put markup directly in the string (1.63 KB, patch)
2015-02-24 13:07 UTC, Alexandre Franke 		committed Details | Review

Description Alexandre Franke 2015-02-24 11:23:37 UTC 
* There's no point in inserting the link the way it was done
* moreover the link was not translatable
* and the order of parameters was wrong anyway, origin_url should be
  fourth not second
Comment 1 Alexandre Franke 2015-02-24 11:38:46 UTC 
Created attachment 297755 [details] [review]
Put markup directly in the string

* There's no point in inserting the link the way it was done
* moreover the link was not translatable
* and the order of parameters was wrong anyway, origin_url should be
  fourth not second
Comment 2 Alexandre Franke 2015-02-24 12:36:40 UTC 
Created attachment 297757 [details] [review]
Put markup directly in the string

* There's no point in inserting the link the way it was done
* moreover the link was not translatable
* and the order of parameters was wrong anyway, origin_url should be
  fourth not second

We should also use https instead of plain http.
Comment 3 Bastien Nocera 2015-02-24 13:06:29 UTC 
Review of attachment 297757 [details] [review]:

You also need to adapt the translator comment above.
Comment 4 Alexandre Franke 2015-02-24 13:07:49 UTC 
Created attachment 297760 [details] [review]
Put markup directly in the string

* There's no point in inserting the link the way it was done
* moreover the link was not translatable
* and the order of parameters was wrong anyway, origin_url should be
  fourth not second

We should also use https instead of plain http.
Comment 5 Matthias Clasen 2015-02-25 01:06:48 UTC 
Review of attachment 297760 [details] [review]:

Looks good now
Comment 6 Alexandre Franke 2015-02-25 18:16:13 UTC 
Attachment 297760 [details] pushed as 05c7011 - Put markup directly in the string