Currently configure.ac only requires "gtk+-3.0 > 3.4", so we shouldn't be depending on any API introduced after that.

We currently require glib 2.32, which was released at the same time as gtk 3.8. If we bump the glib req to 2.34 as suggested in some other bug, then that would correspond to gtk 3.10. So maybe we should bump the gtk requirement too.

Also note that if you change the GDK_VERSION_MIN_REQUIRED in configure.ac to a higher version number, then you'll probably get a whole lot more deprecation warnings in the code itself.

I think we should bump to glib-2.34 (which is over 2 years old, and is in most distributions from late 2012) so it would certainly make sense to bump the GTK requirement to 3.10 at the same time.   But yeah that means we can't rely on stuff that is newer than 3.10, though we can remove things that are deprecated in later GTK versions as long as the changes don't make it look awful on 3.10/3.12.

> ui: use margin_{start,end} instead of margin_{left,right}
> ui: drop GtkAligments where they serve no purpose

I don't think we can change these yet since they are only introduced in GTK 3.12+.  But if removing them still looks OK on GTK 3.10 then we could...  F20 has 3.10 so that would be an OK test platform if you have one lying around.

> ui: drop rest of GtkAlignments

I think this one is OK, but the commit message references "margin" properties though the code doesn't change/set any margin stuff.  If it does actually touch margin stuff somewhere, then maybe we have the same problem as above?

I'm happy if the uncontroversial patches get merged ASAP?

Merged these:

52ceadb ui: drop use of stock icons
d07d0dc ui: use GtkWidget::valign instead of GtkMisc::yalign
b2ea9ce ui: drop xalign from buttons
29d941f ui: drop stock buttons
2f147d8 ui: remove use of rules_hint treeview property

(In reply to Dan Williams from comment #3)
> > ui: use margin_{start,end} instead of margin_{left,right}
> > ui: drop GtkAligments where they serve no purpose
> 
> I don't think we can change these yet since they are only introduced in GTK
> 3.12+.  But if removing them still looks OK on GTK 3.10 then we could... 
> F20 has 3.10 so that would be an OK test platform if you have one lying
> around.
> 
> > ui: drop rest of GtkAlignments
> 
> I think this one is OK, but the commit message references "margin"
> properties though the code doesn't change/set any margin stuff.  If it does
> actually touch margin stuff somewhere, then maybe we have the same problem
> as above?

I've tried to create each kind of connection on f20 and nothing looked particularly broken. Of course I got tons of unknown property warnings.

I'd say the remaining tree are safe to merge as well.

(In reply to Lubomir Rintel from comment #5)
> (In reply to Dan Williams from comment #3)
> > > ui: use margin_{start,end} instead of margin_{left,right}
> > > ui: drop GtkAligments where they serve no purpose
> > 
> > I don't think we can change these yet since they are only introduced in GTK
> > 3.12+.  But if removing them still looks OK on GTK 3.10 then we could... 
> > F20 has 3.10 so that would be an OK test platform if you have one lying
> > around.
> > 
> > > ui: drop rest of GtkAlignments
> > 
> > I think this one is OK, but the commit message references "margin"
> > properties though the code doesn't change/set any margin stuff.  If it does
> > actually touch margin stuff somewhere, then maybe we have the same problem
> > as above?
> 
> I've tried to create each kind of connection on f20 and nothing looked
> particularly broken. Of course I got tons of unknown property warnings.
> 
> I'd say the remaining tree are safe to merge as well.

Ok, sounds fine to me.  3.10 came out on 2013-09-23, quite a while ago, and since this is on git master I think that's fine.

9a64daf ui: merge branch 'lr/gtk-deprecations'
27d483f ui: drop rest of GtkAlignments
e44f2ad ui: drop GtkAligments where they serve no purpose
0a415c8 ui: use margin_{start,end} instead of margin_{left,right}

Pushed; hopefully will not cause any trouble.