GNOME Bugzilla – Bug 744787
openSUSE build root policy: no-return-in-nonvoid-function
Last modified: 2015-02-20 15:32:10 UTC
The openSUSE Build Service raises a flag for [ 55s] I: Program returns random data in a function [ 55s] E: gdm no-return-in-nonvoid-function gdm-common.c:850 [ 55s] E: gdm no-return-in-nonvoid-function gdm-user-switching.c:597 This can happen when CONSOLEKIT is disabled (As is newly the case) and LOGINF_RUNNING would return false.
Created attachment 297272 [details] [review] Attept to fix this
Created attachment 297278 [details] [review] user-switching: Make sure all exit paths have return values The openSUSE Build Service raises a flag for [ 55s] I: Program returns random data in a function [ 55s] E: gdm no-return-in-nonvoid-function gdm-common.c:850 [ 55s] E: gdm no-return-in-nonvoid-function gdm-user-switching.c:597 This can happen when CONSOLEKIT is disabled (As is newly the case) and LOGING_RUNNING would return false. Based on a patch by Dominique Leuenberger
Attachment 297278 [details] pushed as d3cd493 - user-switching: Make sure all exit paths have return values
Created attachment 297412 [details] [review] gdm-wayland-session: initialize local pointers to NULL We follow the "goto out" idiom for error handling, and so it's important that pointers cleaned up at out time, are initialized. This commit does a sweep and nullifies them across the board.
Created attachment 297413 [details] [review] gdm-x-session: initialize local pointers to NULL We follow the "goto out" idiom for error handling, and so it's important that pointers cleaned up at out time, are initialized. This commit does a sweep and nullifies them across the board.
Created attachment 297414 [details] [review] gdm-wayland-session: fix debug message It says "could not start X server" when failing to start the dbus-daemon.
Created attachment 297415 [details] [review] gdm-x-session: fix debug message It says "could not start X server" when failing to start the dbus-daemon.
Created attachment 297416 [details] [review] gdm-wayland-session: don't hardcode path to dbus-daemon It's not always in BINDIR, but it is always in the PATH, so just let the shell/execvp figure it out.
Created attachment 297417 [details] [review] gdm-x-session: don't hardcode path to dbus-daemon It's not always in BINDIR, but it is always in the PATH, so just let the shell/execvp figure it out.
Attachment 297412 [details] pushed as 7981fe4 - gdm-wayland-session: initialize local pointers to NULL Attachment 297413 [details] pushed as c486068 - gdm-x-session: initialize local pointers to NULL Attachment 297414 [details] pushed as 263d78a - gdm-wayland-session: fix debug message Attachment 297415 [details] pushed as 71ebbc4 - gdm-x-session: fix debug message Attachment 297416 [details] pushed as 462cb48 - gdm-wayland-session: don't hardcode path to dbus-daemon Attachment 297417 [details] pushed as 6d8a510 - gdm-x-session: don't hardcode path to dbus-daemon
woops put these on the wrong bug