After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744654 - Add a pre-commit hook to check puppet-lint compliance
Add a pre-commit hook to check puppet-lint compliance
Status: RESOLVED FIXED
Product: sysadmin
Classification: Infrastructure
Component: Apprentices
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Sysadmins
GNOME Sysadmins
Depends on:
Blocks:
 
 
Reported: 2015-02-17 12:08 UTC by Daniel Mustieles
Modified: 2016-11-25 19:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Pre-commit hook to check lint compliance (303 bytes, application/x-shellscript)
2015-02-17 12:08 UTC, Daniel Mustieles 		Details

Description Daniel Mustieles 2015-02-17 12:08:28 UTC 
Created attachment 297015 [details]
Pre-commit hook to check lint compliance

Now we are making .pp files lint-compliant, maybe it's interesting to add a pre-commit hook to puppet's git to avoid commiting files with lint errors.

Attatched is a first proposal to do this. Hope you find it useful.

Cheers!
Comment 1 Andrea Veri 2016-09-19 19:02:17 UTC 
Hey Daniel! can you please look around at already existent pre-receive hooks and cook something for the GNOME Infrastructure if you are interested?
Comment 2 Daniel Mustieles 2016-09-20 09:21:37 UTC 
Sure! I'll try to look into it this week, once the new version be released...

Cheers!
Comment 3 Daniel Mustieles 2016-09-22 13:35:18 UTC 
Is the patch attached to this bug valid or should I to fix it?
Comment 4 Andrea Veri 2016-09-22 13:54:54 UTC 
Actually we want a pre-receive hook and not a pre-commit one, there's some you can find around the web and adapt to our infrastructure, as an example [1].

[1] https://github.com/drwahl/puppet-git-hooks/blob/master/pre-receive
Comment 5 Daniel Mustieles 2016-09-22 14:05:59 UTC 
Ahm, ok, ok. I will investigate it.

Thanks!
Comment 6 Andrea Veri 2016-11-25 19:02:22 UTC 
A pre-receive hook is now in place. Marking as resolved.