After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744632 - Graph import loses fonts: ods, xls, xlsx
Graph import loses fonts: ods, xls, xlsx
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: import/export OOo / OASIS
git master
Other All
: Normal normal
: ---
Assigned To: Andreas J. Guelzow
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2015-02-16 23:48 UTC by Morten Welinder
Modified: 2015-02-17 16:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Morten Welinder 2015-02-16 23:48:25 UTC 
I activated font theming for GOStyle in graphs.

That has caused font to be lost on import from ods, xls, and xlsx because
style->font.auto_font isn't being cleared when an explicit font is set.
Comment 1 Morten Welinder 2015-02-17 00:45:06 UTC 
xlsx fixed
Comment 2 Morten Welinder 2015-02-17 01:05:40 UTC 
xls fixed.
Comment 3 Andreas J. Guelzow 2015-02-17 05:29:41 UTC 
Hmm, regarding xlsx:

static gboolean
xlsx_go_style_has_font (GOStyle *style)
{
	GOFont const *def;
	gboolean is_def;

	if (!(style->interesting_fields & GO_STYLE_FONT))
		return FALSE;

	/* We need to fix auto_font! */

	def = go_font_new_by_index (0);
	is_def = (style->font.font == def);
	go_font_unref (def);

	if (is_def)
		return FALSE;

	return TRUE /* !style->font.auto_font */;
}

There is still a claim that auto_font needs to be fixed.
Comment 4 Andreas J. Guelzow 2015-02-17 06:45:32 UTC 
ods fixed
Comment 5 Morten Welinder 2015-02-17 16:05:55 UTC 
xlsx issue fixed.