GNOME Bugzilla – Bug 744620
Element fail to post error messages when returning GST_FLOW_ERROR
Last modified: 2015-04-19 07:44:46 UTC
Created attachment 296974 [details] [review] decode: Emit error GstMessage when returning a GST_FLOW_ERROR All GStreamer elements MUST post an ERROR GstMessage before returning GST_FLOW_ERROR. The vaapi elements never do. I'm attaching a patch that should do it for the decoder path.
Pushed, Thanks for the patch. commit aaf4165819ab3fee975e00dcfe754d665b3da3af Author: Olivier Crete <olivier.crete@collabora.com> Date: Wed Feb 18 11:19:26 2015 +0200 vaapidecode: Emit error GstMessage when returning a GST_FLOW_ERROR This is required in GStreamer, elements should never return GST_FLOW_ERROR without posting an ERROR message on the bus. https://bugzilla.gnome.org/show_bug.cgi?id=744620
You may also want to use GST_VIDEO_DECODER_ERROR(), to avoid erroring out on the first error if possible.
Created attachment 301871 [details] [review] vaapidecode: Use the GstVideoDecoder error reporting function This way, the decoder won't stop on the first decoding error, in most cases it can recover after some glitchiness.
Make it use the baseclass as appropriate to return errors, it seems to work. Please confirm that nothing expects the decoding to just fail on the first errror?
(In reply to Olivier Crête from comment #4) > Make it use the baseclass as appropriate to return errors, it seems to work. > Please confirm that nothing expects the decoding to just fail on the first > errror? Let's assume that for now :) commit 7e08786e1d38bf98c3aba2ad6d3498f0dfca07d3 Author: Olivier Crete <olivier.crete@collabora.com> Date: Thu Apr 16 20:18:13 2015 -0400 vaapidecode: Use the GstVideoDecoder error reporting function This way, the decoder won't stop on the first decoding error, in most cases it can recover after some glitchiness. https://bugzilla.gnome.org/show_bug.cgi?id=744620