GNOME Bugzilla – Bug 744589
nautilus bookmarks changing places randomly
Last modified: 2017-08-31 16:25:17 UTC
Every time on when opening nautilus bookmarks seems to reaorder randomly, they move up or down in the list.
can you try with master or 3.15.90? I think it was a bug on GTK+ already fixed
It's not fixed, I have seen some random visual glitches changing the ordering very quick every few seconds.
-> gtk+ In that case, this is probably a bug in GtkPlacesSidebar. Do you have a set of steps to reproduce it?
(In reply to Cosimo Cecchi from comment #3) > -> gtk+ > > In that case, this is probably a bug in GtkPlacesSidebar. Do you have a set > of steps to reproduce it? I didn't changed the product because we have a sidebar product in nautilus. Probably is time to remove it from nautilus then =) No, I don't have a reproducer. It needs investigation in the code of ordering of the bookmarks to catch what changes every few seconds. But since we will have a student working on GtkPlacesSidebar this gsoc I'm trying to let this kind of bugs to the student to get used to the code.
I've fixed at least one ordering bug in the places sidebar code semi-recently.
(In reply to Matthias Clasen from comment #5) > I've fixed at least one ordering bug in the places sidebar code > semi-recently. It is what I though was "the fix" in comment 2, but it's actually still happening.
in that case, new debugging is needed
Created attachment 298580 [details] [review] places sidebar: compare bookmarks by index GtkPlacesSidebar applies a sorting function on the tree model that does not consider the case of bookmarks, which are sorted by their indexes. By adding the bookmarks corner case and comparing then by their indexes, GtkPlacesSidebar can sort the bookmarks properly in the order they're saved.
Review of attachment 298580 [details] [review]: Looks fine to me, thanks
Attachment 298580 [details] pushed as ce9a5a3 - places sidebar: compare bookmarks by index
*** Bug 770896 has been marked as a duplicate of this bug. ***