After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744575 - Signals not disconnected in dash
Signals not disconnected in dash
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: overview
3.14.x
Other Linux
: Normal minor
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-02-15 21:31 UTC by Michele
Modified: 2015-02-27 13:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dash: Fix leaking signal connections (1.17 KB, patch)
2015-02-27 01:16 UTC, Florian Müllner 		committed Details | Review

Description Michele 2015-02-15 21:31:03 UTC 
Dash._hookUpLabel() connects each appIcon to the overview 'hiding' signal in order to remove the app labels. However, the signal keep being connected even after the corresponding DashItemContainer is destroyed,  i.e. if the launcher is removed from the dash for instance because the application is closed. 

It seems that these signals accumulate as more applications are closed/re-opened, which is not desirable.
Comment 1 Florian Müllner 2015-02-27 01:16:48 UTC 
Created attachment 298054 [details] [review]
dash: Fix leaking signal connections

The overview has a longer life-time than dash items, so we are
leaking a signal connection each time an item is destroyed.
Spotted by Michele (<micxgx@gmail.com>)
Comment 2 drago01 2015-02-27 12:38:40 UTC 
Review of attachment 298054 [details] [review]:

LG.
Comment 3 Florian Müllner 2015-02-27 13:25:46 UTC 
Attachment 298054 [details] pushed as 714bc5f - dash: Fix leaking signal connections