After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744498 - panelMenu: Consider vertical margins when computing max-height
panelMenu: Consider vertical margins when computing max-height
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-02-13 22:32 UTC by Florian Müllner
Modified: 2015-02-20 17:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
panelMenu: Consider vertical margins when computing max-height (1.72 KB, patch)
2015-02-13 22:32 UTC, Florian Müllner 		needs-work Details | Review
panelMenu: Consider vertical margins when computing max-height (1.78 KB, patch)
2015-02-15 09:24 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2015-02-13 22:32:09 UTC 
See patch.
Comment 1 Florian Müllner 2015-02-13 22:32:13 UTC 
Created attachment 296805 [details] [review]
panelMenu: Consider vertical margins when computing max-height

When opening a panel menu, we set it's max-height to the available
work-area height to keep menus with scrollable content from growing
outside the monitor. However a menu that extends all the way down
to the bottom edge does not look great either, so also take margins
into account here.
Comment 2 Rui Matos 2015-02-14 22:08:26 UTC 
Review of attachment 296805 [details] [review]:

::: data/theme/gnome-shell.css
@@ +171,3 @@
 .popup-menu {
     min-width: 200px;
+    margin-bottom: 1.75em;

We need to use a more specific selector for this so that it only applies to PopupMenus attached to PanelMenuButtons I'm afraid.

Try for instance opening a WindowMenu or a BackgroundMenu near the bottom so that they are forced to flip and you'll see that this margin makes them move away from the pointer too much.
Comment 3 Florian Müllner 2015-02-15 09:24:30 UTC 
Created attachment 296861 [details] [review]
panelMenu: Consider vertical margins when computing max-height

Oh, good catch ...
Comment 4 Rui Matos 2015-02-15 15:14:35 UTC 
Review of attachment 296861 [details] [review]:

ok
Comment 5 Florian Müllner 2015-02-20 17:24:47 UTC 
Uhm, this was pushed a while ago

Attachment 296861 [details] pushed as 7bb7734 - panelMenu: Consider vertical margins when computing max-height