After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744310 - Remove deprecated property
Remove deprecated property
Status: RESOLVED FIXED
Product: gedit-plugins
Classification: Other
Component: General
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-11 06:32 UTC by Sagar Gangurde
Modified: 2019-03-23 20:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove xalign property (1.49 KB, patch)
2015-02-11 06:36 UTC, Sagar Gangurde
accepted-commit_now Details | Review
Remove xalign property (2.05 KB, patch)
2015-02-11 06:47 UTC, Sagar Gangurde
accepted-commit_now Details | Review

Description Sagar Gangurde 2015-02-11 06:32:57 UTC
time plugins using the xalign.
Comment 1 Sagar Gangurde 2015-02-11 06:36:35 UTC
Created attachment 296559 [details] [review]
Remove xalign property
Comment 2 Sagar Gangurde 2015-02-11 06:47:49 UTC
Created attachment 296561 [details] [review]
Remove xalign property
Comment 3 Ignacio Casal Quinteiro (nacho) 2015-02-11 07:14:21 UTC
Review of attachment 296561 [details] [review]:

Looks good.
Comment 4 Sagar Gangurde 2015-02-11 13:23:35 UTC
First one is also a different patch for file : gedit-time-dialog.ui

I think you missed this due to the same name maybe :)
Comment 5 Sébastien Wilmet 2015-02-15 21:06:08 UTC
Review of attachment 296559 [details] [review]:

Looks good.
Comment 6 Sébastien Wilmet 2015-02-15 21:07:40 UTC
You can also squash the commits, they do the same thing.
Comment 7 Sagar Gangurde 2015-02-20 13:49:59 UTC
As the propoerties are affecting the two different files that's why I submitted two separate patches. If squashing is ok then I will re-submit the patch. :)