GNOME Bugzilla – Bug 744133
gnome-nettool doesn't fit with GNOME3 HIG
Last modified: 2021-05-25 11:27:26 UTC
Created attachment 296332 [details] [review] The patch I mention in the description Please see the bug #744125 first. Nettool uses a menubar for few menu items, and a notebook for static tabs. It should use an appmenu or a menubutton and a stack with a stackswitcher instead. I wrote a patch to fix it (with a menubutton). Drawbacks: - gtkstack holds as a child property the title of its child, and the stackswitcher generates labels with it: the page_label member of the _Netinfo struct cannot point to this widget easily. - netinfo_toggle_state uses page_label to set the font to either normal or bold according to the state of the background process. This is no longer the case in my patch (anyway, I guess nobody saw this effect). - as the label is still necessary to display its text if an error happens, I changed it to a gchar*. Its value is defined inside the code, and could be read thanks to the stack, using gtk_container_child_get.
Created attachment 296352 [details] [review] ability to set a tool from CLI implemented back I have omitted to re-implement the selection of a tool from the command line interface. This patch add it back.
Created attachment 296375 [details] [review] Portage to GtkHeaderBar with CLI working - whitespaces removed The sum of the changes of the two above patches, without the whitespaces changes.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/gnome-nettool/-/issues/ Thank you for your understanding and your help.