GNOME Bugzilla – Bug 744028
video-converter: Converter doesn't work properly when offsets are specified
Last modified: 2015-02-06 10:50:08 UTC
In videobox, I tried to use video-converter APIs for format conversions. While creating a new converter, I provided configuration structure with GST_VIDEO_CONVERTER_OPT_SRC_X, SRC_Y, DEST_X and DEST_Y as offsets. for pipeline, gst-launch-1.0 videotestsrc ! "video/x-raw,format={AYUV}" ! videobox left=-20 top=-20 ! "video/x-raw,format={BGRA}" ! videoconvert ! ximagesink DEST_X = DEST_Y = 20 Expected result: Borders should be added at left and top. Actual result: Borders were at right and bottom. Video-converter fetches a fast path for this conversion, which uses ORC generated conversion function. And they do not consider x and y offsets, hence borders weren't added at left and top.
Created attachment 296168 [details] [review] do not use fastpath when offsets are specified I do not know video-converter very well, but this patch worked for me. Please review.
Thanks, I changed it a little so that we can enable certain fastpaths again when we implement crop/border for them later. commit 36a50778af85ad8b807e11f3f0bb9d67e1ac716a Author: Wim Taymans <wtaymans@redhat.com> Date: Thu Feb 5 15:03:24 2015 +0100 video-converter: disable fastpath for crop and border Add crop and border properties to the fastpath table and only select fastpath functions when it can handle the cropping or borders. Fixes https://bugzilla.gnome.org/show_bug.cgi?id=744028