After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743969 - No buttons available to close the preferences dialog
No buttons available to close the preferences dialog
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: ux
0.9.x
Other Linux
: Normal normal
: 0.12.0
Assigned To: Geary Maintainers
Geary Maintainers
Depends on: 764812
Blocks:
 
 
Reported: 2015-02-04 09:01 UTC by Age Bosma (IRC: Forage)
Modified: 2016-05-21 02:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of preferences dialog without closing buttons (25.51 KB, image/png)
2015-02-04 09:01 UTC, Age Bosma (IRC: Forage)
Details
Ubuntu 14.10 GNOME 3.14 preferences dialog screenshot (26.33 KB, image/png)
2015-02-05 16:12 UTC, Age Bosma (IRC: Forage)
Details
Screenshot of Geary 0.8.3 preferences dialog U14.04G3.12 (27.89 KB, image/png)
2015-02-06 08:43 UTC, Age Bosma (IRC: Forage)
Details

Description Age Bosma (IRC: Forage) 2015-02-04 09:01:22 UTC
Created attachment 296078 [details]
Screenshot of preferences dialog without closing buttons

The preferences dialog has no buttons to be able to close the dialog again. No OK-Cancel, no X.
Attached you'll find a screenshot illustrating the issue.

The only way I can do it now is by using the Escape key, which is probably not desired for a lot of users.

Specs:
- Geary 201502031631~0.9.1+1704~ubuntu14.04.1
- Ubuntu GNOME 14.04
- GNOME 3.12

Let me know if you need any more information.
Comment 1 Jim Nelson 2015-02-04 22:40:20 UTC
Are you using Ambiance as your theme?  I also assume you're using GNOME Shell?
Comment 2 Robert Schroll 2015-02-05 00:06:16 UTC
That looks to me like Adwaita.  It also looks like the headerbar is missing completely.  The title should be "Preferences", not "Geary".  I bet the headerbar didn't get put in place for some reason, so the WM decorated it with a default titlebar.

I'm surprised to hear that Ubuntu Gnome 14.04 has Gnome 3.12 -- vanilla Ubuntu 14.04 only has Gnome 3.10 and GTK 3.10 (and not entirely, either).  Did that come with the stock install, or have you installed 3.12 from a PPA or similar?  I'm wondering if some bad mixture of versions is causing the headerbar to be missed when loading the preferences.glade file.
Comment 3 Jim Nelson 2015-02-05 00:31:04 UTC
> I'm surprised to hear that Ubuntu Gnome 14.04 has Gnome 3.12

This is what was throwing me off, as well as the fact that I don't see this in 14.04 Adwaita.  I *do* see it in 14.10 w/ Adwaita (which is GTK+ 3.12) but not the 15.04 beta.  So I'm a touch confused.

One other thing the reporter can do is run Geary like this at the console:

$ geary --version

To be sure they're running 0.9.1 and not an older version.
Comment 4 Age Bosma (IRC: Forage) 2015-02-05 12:20:12 UTC
I'm running:
- geary 0.9.1 (running "geary --version")
- Ubuntu GNOME 14.04
- with GNOME Shell
- default Adwaita theme
- GNOME 3.12 from the gnome-staging ppa indeed

I'll check my system at home with Ubuntu GNOME 14.10 and GNOME 3.14 (from ppa) to see what's happening there later on today.
Comment 5 Age Bosma (IRC: Forage) 2015-02-05 16:12:16 UTC
Created attachment 296204 [details]
Ubuntu 14.10 GNOME 3.14 preferences dialog screenshot

Attached you find a screenshot of how the dialog looks in Ubuntu GNOME 14.10 with GNOME 3.14. Again in version 0.9.1 (from daily ppa). Note the version differences in Ubuntu as well as GNOME.

The header bar is properly visible now.
Comment 6 Jim Nelson 2015-02-05 23:53:21 UTC
This update landed yesterday.  I have to wonder if it's related:

https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1276177

Age, have you seen this for a while, or is it recent?
Comment 7 Jim Nelson 2015-02-06 00:10:51 UTC
So, at this point I'm seeing and hearing this:

Ubuntu 14.04, GTK+ 3.10: Yes
GNOME 14.04, GTK+ 3.12: No

Ubuntu 14.10, GTK+ 3.12: No
GNOME 14.10, GTK+ 3.14: Yes

Ubuntu 15.04, GTK+ 3.14: Yes
Comment 8 Age Bosma (IRC: Forage) 2015-02-06 08:43:42 UTC
Created attachment 296256 [details]
Screenshot of Geary 0.8.3 preferences dialog U14.04G3.12

(In reply to comment #6)
> This update landed yesterday.  I have to wonder if it's related:
> 
> https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1276177
> 

That's a fix in Unity, I don't even have Unity installed because I'm using GNOME Shell.

> Age, have you seen this for a while, or is it recent?

I just installed Geary again because of the added HTML signature support, so I'm not able to tell you if the problems were present earlier as well.

Attached a screenshot of Geary 0.8.3 on the initial platform: Ubuntu GNOME 14.04 + GNOME 3.12.
It has close button, no headerbar, "Preferences" in the dialog title.

Though I suspect the headerbar usage was introduced in 0.9.x and you are more interested in tests of earlier 0.9.x versions. Unfortunately launchpad has no such option for ppa's, as far as I know.
Comment 9 Michael Gratton 2016-05-21 02:56:48 UTC
Fixed by virtue of master now requiring 3.14 per bug 764812.