After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743901 - Favorite Playlist and Starring implementation
Favorite Playlist and Starring implementation
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.15.x
Other All
: Normal normal
: 3.14
Assigned To: gnome-music-maint
gnome-music-maint
Depends on: 743922
Blocks:
 
 
Reported: 2015-02-03 00:54 UTC by Maia
Modified: 2015-02-28 15:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
FAVORITES PLAYLIST AND FAVORITE-STARRING (17.56 KB, patch)
2015-02-03 00:56 UTC, Maia
none Details | Review

Description Maia 2015-02-03 00:54:36 UTC
The following patch implements toggle-able stars in the Songs and Playlists views to mark a song as favorite/non. Favorite songs are automatically added to the Favorite Songs playlist. Favorite status is recorded in tracker by means of the `nao:hasTag nao:predefined-tag-favorite` property.

ISSUES TO BE RESOLVED: [MediaAudio object].get/set_favourite() methods are currently not working. I've hacked around this by storing the favorite value in [MediaAudio object].get/set_lyrics() (an empty string -- "" -- is False, any non-empty string value is True). (Note that this does not store any data in nmm:lyrics or similar in tracker.) Obviously this vastly un-ideal and hard to read and should be fixed as soon as we can get get/set_favourite() working.
Comment 1 Maia 2015-02-03 00:56:43 UTC
Created attachment 295988 [details] [review]
FAVORITES PLAYLIST AND FAVORITE-STARRING
Comment 2 Vadim Rutkovsky 2015-02-03 11:09:42 UTC
Looks got to me, get/set_lyrics should be replaced after Bug 743922 is fixed
Comment 3 Vadim Rutkovsky 2015-02-10 11:28:47 UTC
Pushed this as https://git.gnome.org/browse/gnome-music/commit/?id=1c66c49, though I'm gonna keep this open as we still use get_lyrics
Comment 4 Vadim Rutkovsky 2015-02-28 15:14:58 UTC
get_lyrics() apparently stays for 3.16, closing this one