After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743804 - Time adjustment notification with 2 identical buttons
Time adjustment notification with 2 identical buttons
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: datetime
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: Kalev Lember
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2015-02-01 14:07 UTC by Lionel Landwerlin
Modified: 2015-02-04 16:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Notification screenshot (52.55 KB, image/png)
2015-02-01 14:07 UTC, Lionel Landwerlin 		  Details
datetime: Don't add more than one Settings button (3.33 KB, patch)
2015-02-04 15:23 UTC, Bastien Nocera 		committed Details | Review
datetime: Remove unneeded checks (3.08 KB, patch)
2015-02-04 15:24 UTC, Bastien Nocera 		committed Details | Review

Description Lionel Landwerlin 2015-02-01 14:07:33 UTC 
Created attachment 295888 [details]
Notification screenshot

Just got a notification with 2 open 'Settings' buttons.
It doesn't seem right.
Comment 1 Bastien Nocera 2015-02-04 15:23:59 UTC 
Created attachment 296135 [details] [review]
datetime: Don't add more than one Settings button

In the notification. We were adding a new Settings button each time
we were updating a notification. We only need to add one the first
time around.
Comment 2 Bastien Nocera 2015-02-04 15:24:04 UTC 
Created attachment 296136 [details] [review]
datetime: Remove unneeded checks

We can assume that gnome-control-center is installed and gnome-shell is
in use, because we're gnome-settings-daemon, not a bag of bits.
Comment 3 Rui Matos 2015-02-04 15:45:11 UTC 
Review of attachment 296135 [details] [review]:

right
Comment 4 Rui Matos 2015-02-04 15:46:27 UTC 
Review of attachment 296136 [details] [review]:

sure
Comment 5 Bastien Nocera 2015-02-04 16:05:53 UTC 
Attachment 296135 [details] pushed as b0afa2a - datetime: Don't add more than one Settings button
Attachment 296136 [details] pushed as 9ba3dc2 - datetime: Remove unneeded checks