Bug 743734 – RTCP packets not sent

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 743734 - RTCP packets not sent


Summary:	RTCP packets not sent


Status:	RESOLVED FIXED

Product:	GStreamer
Classification:	Platform
Component:	gst-rtsp-server
Version:	git master
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	1.5.1
Assigned To:	GStreamer Maintainers
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2015-01-30 11:36 UTC by anila
Modified:	2015-01-30 17:26 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Proposed patch (2.70 KB, patch) 2015-01-30 14:58 UTC, anila	committed	Details \| Review

Description anila 2015-01-30 11:36:16 UTC

RTCP packets were not sent because the same tr_cache_cookie was used for
both RTP and RTCP. So only one of the tr_cache lists were populated
depending on which one was sent first. If the tr_cache list is not
populated then no packets can be sent. Most often this happened to be RTCP.

Comment 1 anila 2015-01-30 14:58:07 UTC

Created attachment 295808 [details] [review]
Proposed patch

Comment 2 Sebastian Dröge (slomo) 2015-01-30 17:25:55 UTC

Thanks for the patch! :)

commit 18668bf49570b3ab75e35dd275f4761f0210cc42
Author: Anila Balavan <anilabn@axis.com>
Date:   Fri Jan 30 12:50:20 2015 +0100

    rtsp-stream: RTCP and RTP transport cache cookies seperated
    
    RTCP packets were not sent because the same tr_cache_cookie was used for
    both RTP and RTCP. So only one of the tr_cache lists were populated
    depending on which one was sent first. If the tr_cache list is not
    populated then no packets can be sent. Most often this happened to be
    RTCP. Now seperate RTCP and RTP transport cache cookies are added which
    resulted in both the tr_cache_lists to be populated regardless of which
    one was sent first.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=743734