After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743678 - wayland: Fix caching of surface state
wayland: Fix caching of surface state
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2015-01-29 07:48 UTC by Jonas Ådahl
Modified: 2015-01-30 04:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wayland: Fix caching of surface state (1.37 KB, patch)
2015-01-29 07:48 UTC, Jonas Ådahl 		committed Details | Review

Description Jonas Ådahl 2015-01-29 07:48:44 UTC 
The commit 97a69cee5a12e11912b09f6617001a7da005f264 broke the caching of
the surface state when because the frame_callback_list target state was
overwritten after the content had been moved to it.

This commit fixes it by moving the frame list addition after the copy. We
also need to initialize the list since the plain copy put garbage in it.
Comment 1 Jonas Ådahl 2015-01-29 07:48:47 UTC 
Created attachment 295725 [details] [review]
wayland: Fix caching of surface state
Comment 2 Jasper St. Pierre (not reading bugmail) 2015-01-29 15:21:23 UTC 
Review of attachment 295725 [details] [review]:

Nice catch, sorry about that.
Comment 3 Jonas Ådahl 2015-01-30 04:21:11 UTC 
Attachment 295725 [details] pushed as 4d23e7c - wayland: Fix caching of surface state