Created attachment 295350 [details] [review]
power: When locking the screen on tablets, also suspend

See https://bugzilla.gnome.org/show_bug.cgi?id=743455 for
details the full reasoning.

Created attachment 295356 [details] [review]
power: When disabling the backlight, also suspend on tablets

See https://bugzilla.gnome.org/show_bug.cgi?id=743455 for
details the full reasoning.

Comment on attachment 295350 [details] [review]
power: When locking the screen on tablets, also suspend

This, smaller, new patch should be enough.

Review of attachment 295356 [details] [review]:

::: plugins/power/gpm-common.c
@@ +193,3 @@
 
+gboolean
+gsd_power_is_hardware_a_tablet (void)

It would be nice to share this code with the similar one in GsdRfkillManager that fetches the chassis type.

Created attachment 295565 [details] [review]
daemon: Add chassis type helper

Created attachment 295566 [details] [review]
power: When disabling the backlight, also suspend on tablets

See https://bugzilla.gnome.org/show_bug.cgi?id=743455 for
details the full reasoning.

Created attachment 295567 [details] [review]
rfkill: Use new chassis type helper

Review of attachment 295565 [details] [review]:

::: gnome-settings-daemon/gnome-settings-bus.c
@@ +160,3 @@
+        }
+
+        variant = g_dbus_connection_call_sync (connection,

Should g_variant_unref(inner) after this

Review of attachment 295566 [details] [review]:

Looks good to me

Review of attachment 295567 [details] [review]:

Looks good

Created attachment 295601 [details] [review]
daemon: Add chassis type helper

Created attachment 295602 [details] [review]
power: Fix a small memory leak

Don't forget to unref the left-over variant.

Review of attachment 295601 [details] [review]:

Looks good

Review of attachment 295602 [details] [review]:

Sure

Attachment 295566 [details] pushed as 983c54c - power: When disabling the backlight, also suspend on tablets
Attachment 295567 [details] pushed as 0698928 - rfkill: Use new chassis type helper
Attachment 295601 [details] pushed as 4092695 - daemon: Add chassis type helper
Attachment 295602 [details] pushed as a9e92f0 - power: Fix a small memory leak

Please make this a configurable option!  This feature has caused me a great deal of annoyance with my "convertible" laptop/tablet, which I generally use as a laptop.  I am not the only one who has been annoyed by this:

https://ask.fedoraproject.org/en/question/76767/unwanted-suspend-when-locking-screen-using-gnome/

This is behavior might make sense on some devices, but it should not be hard-coded.

(In reply to Benjamin Kreuter from comment #16)
> Please make this a configurable option!  This feature has caused me a great
> deal of annoyance with my "convertible" laptop/tablet, which I generally use
> as a laptop.  I am not the only one who has been annoyed by this:
> 
> https://ask.fedoraproject.org/en/question/76767/unwanted-suspend-when-
> locking-screen-using-gnome/
> 
> This is behavior might make sense on some devices, but it should not be
> hard-coded.

If you machine suspends, that means it advertises itself as a tablet. Read "man machine-info" and change the chassis type to match the actual type then.

Changing the chassis type to 'laptop' does work -- but then the machine suspends whenever I switch between laptop and tablet mode, which is less annoying but which is still annoying.  I am also hesitant to rely on manually setting the chassis type as anything more than a temporary workaround, since the problem is not the chassis type ('laptop' is not any more correct than 'tablet' for this machine).

Then file a new bug, this code has already been shipped in 3 stable releases, there's no cause to reopen this one.

(In reply to Bastien Nocera from comment #19)
> Then file a new bug, this code has already been shipped in 3 stable
> releases, there's no cause to reopen this one.

For the benefit of others ending up here: see bug 764723 and bug 779300.