Bug 743412 – monitor-manager: Initialize MetaOutput even when we can't get the EDID

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 743412 - monitor-manager: Initialize MetaOutput even when we can't get the EDID


Summary:	monitor-manager: Initialize MetaOutput even when we can't get the EDID


Status:	RESOLVED FIXED

Product:	mutter
Classification:	Core
Component:	general
Version:	unspecified
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	mutter-maint
QA Contact:	mutter-maint

URL:
Whiteboard:

Duplicates:	743504 744708 (view as bug list)
Depends on:
Blocks:

Reported:	2015-01-23 16:37 UTC by Rui Matos
Modified:	2015-02-18 14:19 UTC

See Also:
GNOME target:	3.16
GNOME version:	---

Attachments
monitor-manager: Initialize MetaOutput even when we can't get the EDID (2.80 KB, patch) 2015-01-23 16:37 UTC, Rui Matos	committed	Details \| Review

Description Rui Matos 2015-01-23 16:37:45 UTC

Should fix this crash from continuous:

Thread 1 (Thread 0x7ff76549b980 (LWP 571)):
../../src/backends/meta-monitor-config.c:157
../../src/backends/meta-monitor-config.c:187
(hash_return=<synthetic pointer>, key=0x7fffb39616b0,
hash_table=0x1222580) at ../../glib/ghash.c:375
key=key@entry=0x7fffb39616b0) at ../../glib/ghash.c:1147
(n_outputs=<optimized out>, outputs=<optimized out>, self=0x1222520)
at ../../src/backends/meta-monitor-config.c:846
manager=manager@entry=0x10932a0) at
../../src/backends/meta-monitor-config.c:1045
(object=<optimized out>) at
../../src/backends/meta-monitor-manager.c:208
class@entry=0x124e150, params=0x7fffb39616b0, params@entry=0x0,
n_params=0) at ../../gobject/gobject.c:1814
(object_type=object_type@entry=19189200,
n_parameters=n_parameters@entry=0, parameters=parameters@entry=0x0) at
../../gobject/gobject.c:1922
first_property_name=0x0) at ../../gobject/gobject.c:1614
(backend=0x107d8c0) at ../../src/backends/meta-backend.c:157
(backend=0x107d8c0) at ../../src/backends/x11/meta-backend-x11.c:421

Comment 1 Rui Matos 2015-01-23 16:37:47 UTC

Created attachment 295285 [details] [review]
monitor-manager: Initialize MetaOutput even when we can't get the EDID

Otherwise we'll crash later when building a MetaConfiguration.

Comment 2 Rui Matos 2015-01-23 16:40:32 UTC

Not sure what happened to the backtrace paste. Here it is again:

+ Trace 234577

Thread 1 (Thread 0x7ff76549b980 (LWP 571))

#0 g_str_hash
at ../../glib/ghash.c line 1859
#1 output_key_hash
at ../../src/backends/meta-monitor-config.c line 157
#2 config_hash
at ../../src/backends/meta-monitor-config.c line 187
#3 g_hash_table_lookup_node
at ../../glib/ghash.c line 375
#4 g_hash_table_lookup
at ../../glib/ghash.c line 1147
#5 meta_monitor_config_get_stored
at ../../src/backends/meta-monitor-config.c line 846
#6 meta_monitor_config_apply_stored
at ../../src/backends/meta-monitor-config.c line 1045
#7 meta_monitor_manager_constructed
at ../../src/backends/meta-monitor-manager.c line 208
#8 g_object_new_internal
at ../../gobject/gobject.c line 1814
#9 g_object_newv
at ../../gobject/gobject.c line 1922
#10 g_object_new
at ../../gobject/gobject.c line 1614
#11 meta_backend_real_post_init
at ../../src/backends/meta-backend.c line 157
#12 meta_backend_x11_post_init
at ../../src/backends/x11/meta-backend-x11.c line 421
#13 meta_init
at ../../src/core/main.c line 358
#14 main
at ../../src/main.c line 429

Comment 3 drago01 2015-01-23 16:40:43 UTC

Review of attachment 295285 [details] [review]:

Can't test it right now but makes sense to me.

Comment 4 Rui Matos 2015-01-26 11:56:19 UTC

*** Bug 743504 has been marked as a duplicate of this bug. ***

Comment 5 Vadim Rutkovsky 2015-01-26 14:07:17 UTC

(In reply to comment #1)
> Created an attachment (id=295285) [details] [review]
> monitor-manager: Initialize MetaOutput even when we can't get the EDID
> 
> Otherwise we'll crash later when building a MetaConfiguration.

Thanks, this unblocked smoketests for me, please push

Comment 6 Rui Matos 2015-01-27 13:44:18 UTC

Ok, pushing to unblock the smoketests, thanks for testing

Attachment 295285 [details] pushed as ad90b7d - monitor-manager: Initialize MetaOutput even when we can't get the EDID

Comment 7 Dominique Leuenberger 2015-02-18 14:19:20 UTC

*** Bug 744708 has been marked as a duplicate of this bug. ***