GNOME Bugzilla – Bug 743387
validate: test all the issues in preparation for the port to tracer.
Last modified: 2018-11-03 11:06:12 UTC
First batch covers some caps related issues.
Created attachment 295247 [details] [review] validate: prepare tests for port to tracers backend.
Created attachment 295248 [details] [review] validate: Add a test case for caps missing field. + Make the fake decoder have video/x-raw caps.
Created attachment 295249 [details] [review] validate: tests more issues with caps.
Review of attachment 295247 [details] [review]: OK ::: validate/tests/check/validate/padmonitor.c @@ +46,3 @@ + (GstValidateMonitor *) g_object_get_data (G_OBJECT (bin), + "validate-monitor"); + check_destroyed (bin, NULL, NULL); You should use the new gst_check_object_destroyed_on_unref function I added in core.
Review of attachment 295248 [details] [review]: OK
Review of attachment 295249 [details] [review]: OK ::: validate/tests/check/validate/padmonitor.c @@ +825,3 @@ + fail_unless (gst_pad_push_event (srcpad, + gst_event_new_caps (gst_caps_from_string + ("video/x-raw, format=AYUV, framerate=24/1, width=(fraction)320, height=240, pixel-aspect-ratio=1/1")))); Would be easier to read if you put 320/1, anyway :)
Created attachment 295469 [details] [review] validate: prepare tests for port to tracers backend.
(In reply to comment #4) > Review of attachment 295247 [details] [review]: > > OK > > ::: validate/tests/check/validate/padmonitor.c > @@ +46,3 @@ > + (GstValidateMonitor *) g_object_get_data (G_OBJECT (bin), > + "validate-monitor"); > + check_destroyed (bin, NULL, NULL); > > You should use the new gst_check_object_destroyed_on_unref function I added in > core. Actually no real need for that, one simply needs to check the refcount before unreffing in this case.
Review of attachment 295469 [details] [review]: commit 887349167b8c2f88befaa52e3e06cc9130b8fd83 Author: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com> Date: Thu Jan 22 22:29:10 2015 +0100 validate: prepare tests for port to tracers backend. https://bugzilla.gnome.org/show_bug.cgi?id=743387
Review of attachment 295248 [details] [review]: commit bf2c949aee1761965e7a411d838a6ab806f99963 Author: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com> Date: Fri Jan 23 01:40:59 2015 +0100 validate: Add a test case for caps missing field. + Make the fake decoder have video/x-raw caps. https://bugzilla.gnome.org/show_bug.cgi?id=743387
Review of attachment 295249 [details] [review]: commit 89048ad862a4038631eba42d913ab4594dfc0fd5 Author: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com> Date: Fri Jan 23 02:04:47 2015 +0100 validate: tests more issues with caps. https://bugzilla.gnome.org/show_bug.cgi?id=743387
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-devtools/issues/9.