After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743307 - Slight UI changes
Slight UI changes
Status: RESOLVED OBSOLETE
Product: gnome-control-center
Classification: Core
Component: Privacy
unspecified
Other All
: Normal normal
: ---
Assigned To: Rui Matos
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-21 17:19 UTC by Bastien Nocera
Modified: 2019-03-01 09:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
privacy: Rename "Show Notifications" label (1.06 KB, patch)
2015-01-28 10:55 UTC, Bastien Nocera 		accepted-commit_now Details | Review
privacy: Dim explanatory label in history dialogue (996 bytes, patch)
2015-01-28 10:56 UTC, Bastien Nocera 		needs-work Details | Review
privacy: Dim explanatory label in purge dialogue (1007 bytes, patch)
2015-01-28 10:56 UTC, Bastien Nocera 		rejected Details | Review
privacy: Reword Purge dialogue (5.98 KB, patch)
2015-01-28 10:56 UTC, Bastien Nocera 		needs-work Details | Review

Comment 1 Bastien Nocera 2015-01-28 10:55:59 UTC 
Created attachment 295635 [details] [review]
privacy: Rename "Show Notifications" label

To be clearer.
Comment 2 Bastien Nocera 2015-01-28 10:56:05 UTC 
Created attachment 295636 [details] [review]
privacy: Dim explanatory label in history dialogue
Comment 3 Bastien Nocera 2015-01-28 10:56:10 UTC 
Created attachment 295637 [details] [review]
privacy: Dim explanatory label in purge dialogue
Comment 4 Bastien Nocera 2015-01-28 10:56:16 UTC 
Created attachment 295638 [details] [review]
privacy: Reword Purge dialogue

And add header labels
Comment 5 Allan Day 2015-02-10 14:34:12 UTC 
Thanks for implementing this Bastien. I've tried the patches; not all the changes seem positive to me, unfortunately.

I've updated the mockups [1], and can provide a list of the changes compared with the patches, if that would be helpful.

[1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/privacy/current-gen.png
Comment 6 Bastien Nocera 2015-08-03 15:10:56 UTC 
(In reply to Allan Day from comment #5)
> Thanks for implementing this Bastien. I've tried the patches; not all the
> changes seem positive to me, unfortunately.
> 
> I've updated the mockups [1], and can provide a list of the changes compared
> with the patches, if that would be helpful.
> 
> [1]
> https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/
> system-settings/privacy/current-gen.png

That would be good, so I can at least mark the patches that we don't want as rejected.
Comment 7 Georges Basile Stavracas Neto 2018-01-23 02:41:02 UTC 
Review of attachment 295635 [details] [review]:

Looks good to me
Comment 8 Georges Basile Stavracas Neto 2018-01-23 02:41:53 UTC 
Review of attachment 295636 [details] [review]:

Doesn't apply on master, and from the discussion, might need an update.
Comment 9 Georges Basile Stavracas Neto 2018-01-23 02:42:37 UTC 
Review of attachment 295637 [details] [review]:

Looks good, but doesn't apply on master.
Comment 10 Georges Basile Stavracas Neto 2018-01-23 02:43:38 UTC 
Review of attachment 295638 [details] [review]:

From the discussion, needs an update (and doesn't apply on master)
Comment 11 Bastien Nocera 2019-03-01 09:34:29 UTC 
Review of attachment 295637 [details] [review]:

Already fixed in bebaf47da1b501ba4a56e2544d7106e88ab6f155
Comment 12 Bastien Nocera 2019-03-01 09:35:01 UTC 
Moved the one patch left-over to https://gitlab.gnome.org/GNOME/gnome-control-center/merge_requests/417