After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743228 - [PATCH] Fixed wrong battery statistic
[PATCH] Fixed wrong battery statistic
Status: RESOLVED FIXED
Product: gnome-battery-bench
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME battery bench maintainer(s)
GNOME battery bench maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-01-20 08:33 UTC by Ettl Martin
Modified: 2015-06-24 15:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix (683 bytes, patch)
2015-01-20 08:33 UTC, Ettl Martin 		none Details | Review
Fix battery life computation when battery units are mAh (1.18 KB, patch)
2015-06-24 15:33 UTC, Owen Taylor 		committed Details | Review

Description Ettl Martin 2015-01-20 08:33:49 UTC 
Created attachment 294956 [details] [review]
proposed fix

Please review the attached patch. It fixes a wrong calculation in statistics of gnome-battery-bench. 

Many thanks and best regards

Martin Ettl
Comment 1 Owen Taylor 2015-06-24 15:33:36 UTC 
Created attachment 306018 [details] [review]
Fix battery life computation when battery units are mAh

Hi Ettl - thanks for the fix! Sorry it took me so long to get to this.

As a suggestion for the future, when submitting a patch, it's best to do
it as a git commit instead of just a diff - that way I can apply it with
the correct Author line and information about what was fixed.
(See https://wiki.gnome.org/GnomeLove/SubmittingPatches)
Since this patch was so simple, I just went ahead and created a commit
myself
Comment 2 Owen Taylor 2015-06-24 15:34:06 UTC 
Attachment 306018 [details] pushed as 89ab482 - Fix battery life computation when battery units are mAh