After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743091 - INCLUDES is the old name for AM_CPPFLAGS
INCLUDES is the old name for AM_CPPFLAGS
Status: RESOLVED OBSOLETE
Product: planner
Classification: Other
Component: Build
0.14.6
Other Linux
: Normal normal
: ---
Assigned To: planner-maint
planner-maint
Depends on:
Blocks:
 
 
Reported: 2015-01-17 16:00 UTC by Ahmed Baïzid
Modified: 2021-06-02 08:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
INCLUDES is the old name for AM_CPPFLAGS (2.74 KB, patch)
2015-01-17 16:00 UTC, Ahmed Baïzid 		none Details | Review

Description Ahmed Baïzid 2015-01-17 16:00:33 UTC 
Created attachment 294740 [details] [review]
INCLUDES is the old name for AM_CPPFLAGS

$ ./autogen.sh
eds-backend/Makefile.am:1: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
eds-backend/planner-source/Makefile.am:1: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
eds-backend/utils/Makefile.am:1: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
libplanner/Makefile.am:1: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
python/Makefile.am:1: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
src/Makefile.am:1: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
tests/Makefile.am:3: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')

Easy :
$ L=$(find -name Makefile.am)
$ perl -i -pe 's/\bINCLUDES\b/AM_CPPFLAGS/g' $L
Comment 1 Alexandre Franke 2017-05-14 22:28:56 UTC 
Maybe we should also rename PYTHON_INCLUDES to PYTHON_CPPFLAGS. What do you think? There doesn’t seem to be a rule about it but it seems to fit the convention.
Comment 2 Mart Raudsepp 2021-06-02 08:51:31 UTC 
Closing this ticket before any mass-closing of bugzilla tickets due to bugzilla shutdown for better extra information:

There is a pending complete port to meson instead of autotools at https://gitlab.gnome.org/World/planner/-/merge_requests/8 which would make this here obsolete