After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742926 - Empty row for remote users
Empty row for remote users
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Ondrej Holy
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-14 15:44 UTC by Ondrej Holy
Modified: 2015-01-15 08:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
don't show empty row for remote users (1.13 KB, patch)
2015-01-14 15:46 UTC, Ondrej Holy
committed Details | Review

Description Ondrej Holy 2015-01-14 15:44:48 UTC
Empty row is shown for remote users instead of hidden autologin switch.
Comment 1 Ondrej Holy 2015-01-14 15:46:52 UTC
Created attachment 294535 [details] [review]
don't show empty row for remote users

Empty row is shown instead of hidden autologin switch, because autologin box is still visible. Set visibility on autologin box to hide this empty row.
Comment 2 Rui Matos 2015-01-14 16:32:24 UTC
Review of attachment 294535 [details] [review]:

a-c-n

But I wonder: why is the switch contained in a box? A quick search doesn't reveal any use for the box.
Comment 3 Ondrej Holy 2015-01-14 17:01:55 UTC
(In reply to comment #2)
> Review of attachment 294535 [details] [review]:
> 
> a-c-n

Thanks for the review!
 
> But I wonder: why is the switch contained in a box? A quick search doesn't
> reveal any use for the box.

Don't know why it was there originally. I wanted to remove it, but then the switch is expanded vertically to have same height as other widgets, what is probably wrong, because it should be vertically aligned to center instead. But I don't know how to do that... Would be best to set row-homogeneous to True and remove those size groups, but the icon and name would have to be moved out from the grid.
Comment 4 Ondrej Holy 2015-01-15 08:51:36 UTC
Comment on attachment 294535 [details] [review]
don't show empty row for remote users

Pushed for master as:
commit b61c74aa607d916eed051a33e98fc53e34fdd50a

and gnome-3-14 as:
commit fa05d4913f512e4411f1ae2945eafb293a662a50