GNOME Bugzilla – Bug 742882
Export exactly the same EDID information on both X11/wayland backends
Last modified: 2015-01-14 13:37:20 UTC
On X11, if no product/serial strings could be parsed from the EDID blob, it falls back to the hexadecimal representations of product_code/serial_number, which still helps somewhat when matching an specific output. I'm attaching a patch to replicate that same behavior on wayland (currently NULLs are returned in these), this way touchscreen/tablet mapping in bug #739397 doesn't need any updating when switching between environments.
Created attachment 294459 [details] [review] backends: Make KMS EDID information equal to X11's If no product name/serial number are found, resort to the raw values. This makes EDID information the same on KMS and and X11, so it can be used consistently on eg. settings keys.
Review of attachment 294459 [details] [review]: Would it be possible to put this in a shared utility function, perhaps in edid-parse.c?
Created attachment 294478 [details] [review] backends: Make KMS EDID information equal to X11's EDID parsing has been refactored to a common meta_output_parse_edid() function, which ensures the extracted information is the same on both KMS and X11 backend, so it can be used consistently on eg. settings values.
(In reply to comment #2) > Review of attachment 294459 [details] [review]: > > Would it be possible to put this in a shared utility function, perhaps in > edid-parse.c? edid-parse is code also copied across g-s-d and others, I felt it was safer to leave it untouched for possible future fixes/merges
Review of attachment 294478 [details] [review]: Looks good.
Attachment 294478 [details] pushed as 625d3de - backends: Make KMS EDID information equal to X11's
(In reply to comment #4) > edid-parse is code also copied across g-s-d and others, I felt it was safer to > leave it untouched for possible future fixes/merges We should probably move it to gnome-desktop in that case.
(In reply to comment #7) > (In reply to comment #4) > > edid-parse is code also copied across g-s-d and others, I felt it was safer to > > leave it untouched for possible future fixes/merges > > We should probably move it to gnome-desktop in that case. Ugh, I actually had the gnome-desktop copy in mind there :), g-s-d has none.