After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742824 - StTextureCache: adapt to MetaWindow changing icon prop type
StTextureCache: adapt to MetaWindow changing icon prop type
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: st
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-01-12 21:27 UTC by Rui Matos
Modified: 2015-01-13 15:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
StTextureCache: adapt to MetaWindow changing icon prop type (6.32 KB, patch)
2015-01-12 21:27 UTC, Rui Matos 		committed Details | Review
MetaWindow: Change icon properties to be of pointer type (2.21 KB, patch)
2015-01-12 21:27 UTC, Rui Matos 		committed Details | Review

Comment 1 Rui Matos 2015-01-12 21:27:25 UTC 
Created attachment 294377 [details] [review]
StTextureCache: adapt to MetaWindow changing icon prop type
Comment 2 Rui Matos 2015-01-12 21:27:53 UTC 
Created attachment 294378 [details] [review]
MetaWindow: Change icon properties to be of pointer type

Follow up to commit af7f51b992b20da543312fa9fdf1dcef39704b37 .
Comment 3 Jasper St. Pierre (not reading bugmail) 2015-01-12 21:33:13 UTC 
Review of attachment 294377 [details] [review]:

OK.
Comment 4 Jasper St. Pierre (not reading bugmail) 2015-01-12 21:33:24 UTC 
Review of attachment 294378 [details] [review]:

Yep.
Comment 5 Rui Matos 2015-01-13 15:07:35 UTC 
Comment on attachment 294378 [details] [review]
MetaWindow: Change icon properties to be of pointer type

Attachment 294378 [details] pushed as 0484ef1 - MetaWindow: Change icon properties to be of pointer type
Comment 6 Rui Matos 2015-01-13 15:12:25 UTC 
The wrong colors mentioned in bug 742825 were actually due to me
misunderstanding the cogl pixel format. The cogl definition is that
each component is listed from the lowest memory address, i.e. what
cairo calls ARGB32 (which is the same as specified for NET_WM_ICON) is
BGRA_8888 in the cogl definition. Pushed with that change.

Attachment 294377 [details] pushed as af88916 - StTextureCache: adapt to MetaWindow changing icon prop type