After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742737 - systeminstall: speed up pkg-config
systeminstall: speed up pkg-config
Status: RESOLVED DUPLICATE of bug 740866
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2015-01-11 02:47 UTC by Allison Karlitskaya (desrt)
Modified: 2015-01-11 12:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
systeminstall: speed up pkg-config (1.74 KB, patch)
2015-01-11 02:47 UTC, Allison Karlitskaya (desrt) 		none Details | Review

Description Allison Karlitskaya (desrt) 2015-01-11 02:47:18 UTC 
The code for building the list of all installed packages is very slow,
particularly when lots of packages are installed.

This "slow and steady" approach was implemented in bug 683832 because of
the potential for broken pkg-config files to break the old approach.

Broken pkg-config files are not normally installed, so we may as well
try to do things the fast way first, falling back on the other approach
if it fails.

This improves 'jhbuild list glib' from ~5.6 to ~0.4 seconds on my fairly
typical system (with 482 .pc files installed).
Comment 1 Allison Karlitskaya (desrt) 2015-01-11 02:47:20 UTC 
Created attachment 294258 [details] [review]
systeminstall: speed up pkg-config
Comment 2 Frederic Peters 2015-01-11 12:16:31 UTC 
There is a duplicate with an accepted patch in bug 740866, but yours is shorter and would be fine (you could use splitlines() instead of strip().split('\n'))

*** This bug has been marked as a duplicate of bug 740866 ***