After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742588 - add dispatcher variable to indicate non-NM activation [danw/dispatcher-external-...]
add dispatcher variable to indicate non-NM activation [danw/dispatcher-extern...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-01-08 14:45 UTC by Dan Winship
Modified: 2015-01-19 16:22 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Dan Winship 2015-01-08 14:45:53 UTC
We call dispatcher scripts for both NM-initiated activations and for activations that NM merely observes. For many dispatcher scripts, this is the right thing, but potentially not for all of them. So this branch adds a CONNECTION_EXTERNAL=1 variable to the dispatcher environment when dispatching events on a generated-assumed connection.

(Note that this is built on top of danw/policy-based-routing-rh1160013. I was going to add a check for !$CONNECTION_EXTERNAL to 10-ifcfg-rh-routes.sh, but realized it's not actually needed since it's effectively covered by the $CONNECTION_FILENAME check.)
Comment 1 Thomas Haller 2015-01-08 14:56:03 UTC
Should also add the new environment variables to the manual page of NetworkManager.conf

Otherwise LGTM
Comment 2 Dan Williams 2015-01-12 23:16:28 UTC
LGTM too, though as Thomas suggests the new env var should be documented.