After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742326 - Refine UI
Refine UI
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: ux
unspecified
Other Linux
: Normal enhancement
: 0.22
Assigned To: Shotwell Maintainers
Shotwell Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-04 15:18 UTC by Trinh Anh Ngoc
Modified: 2015-01-06 02:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot (693.12 KB, image/png)
2015-01-04 15:18 UTC, Trinh Anh Ngoc 		  Details
Refine main UI (14.37 KB, patch)
2015-01-04 15:19 UTC, Trinh Anh Ngoc 		none Details | Review
Screenshot (227.47 KB, image/png)
2015-01-04 15:24 UTC, Trinh Anh Ngoc 		  Details
Refine dialogs (28.62 KB, patch)
2015-01-04 15:30 UTC, Trinh Anh Ngoc 		none Details | Review

Description Trinh Anh Ngoc 2015-01-04 15:18:38 UTC 
Created attachment 293709 [details]
Screenshot

Refine main UI:
- Adjust paned handler separator
- Remove ugly style in search bar
...
Comment 1 Trinh Anh Ngoc 2015-01-04 15:19:41 UTC 
Created attachment 293710 [details] [review]
Refine main UI
Comment 2 Trinh Anh Ngoc 2015-01-04 15:24:45 UTC 
Created attachment 293711 [details]
Screenshot

Refine dialogs
Comment 3 Trinh Anh Ngoc 2015-01-04 15:30:21 UTC 
Created attachment 293713 [details] [review]
Refine dialogs
Comment 4 Jim Nelson 2015-01-06 02:56:13 UTC 
Fantastic!  This is a UI refresh that Shotwell has needed for some time now.  Thanks for taking this upon yourself and making it happen.  And thank you for breaking this up into separate patches, which makes them easier to review and commit.

I've made small tweaks to your patch to conform to Yorba's guidelines and practices.  (For example, we don't use "var" variables; use warning() sparingly, as G_DEBUG=fatal-warnings will cause an abort, etc.)

Also, your dialogs patch doesn't update the Smart Search editor dialog.  Is it possible you could give that a go?

Pushed to master, commit b5501d and commit 31bb62.