After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742243 - GtkScrolledWindow draws overshoot at the wrong position
GtkScrolledWindow draws overshoot at the wrong position
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkScrolledWindow
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
: 742700 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-01-02 21:58 UTC by Timm Bäder
Modified: 2015-01-19 12:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GtkScrolledWindow: Fix overshoot indicator position (1.73 KB, patch)
2015-01-02 21:58 UTC, Timm Bäder
none Details | Review
scrolledwindow: Don't displace invalidation by the widget allocation (1.64 KB, patch)
2015-01-19 12:12 UTC, Carlos Garnacho
committed Details | Review

Description Timm Bäder 2015-01-02 21:58:12 UTC
Created attachment 293621 [details] [review]
GtkScrolledWindow: Fix overshoot indicator position

For example in the filechooser: http://i.imgur.com/isUqqzA.png

As far as I know, this is related to fdf367e8689cb8 which makes GtkScrolledWindow a windowed widget again and these coordinates are just leftovers which have not been updated. I'm not entirely sure if the attached patch is the correct way to fix this or if gtk_scrolled_window_relative_allocation should instead to that directly (but that's used in more places and I didn't want to touch that much).
Comment 1 Matthias Clasen 2015-01-10 19:29:57 UTC
*** Bug 742700 has been marked as a duplicate of this bug. ***
Comment 2 Carlos Garnacho 2015-01-19 12:12:15 UTC
Thanks Timm for the patch! I'm however going for a simplified version, there's no need to fetch/use the allocation if the only used fields are first added and then subtracted.
Comment 3 Carlos Garnacho 2015-01-19 12:12:44 UTC
The following fix has been pushed:
dc952e3 scrolledwindow: Don't displace invalidation by the widget allocation
Comment 4 Carlos Garnacho 2015-01-19 12:12:49 UTC
Created attachment 294863 [details] [review]
scrolledwindow: Don't displace invalidation by the widget allocation

This was left unmodified when GtkScrolledWindow was made a windowed widget.
Displacing here by the widget allocation is not necessary anymore, since
we are invalidating the window set at these coordinates.

This patch is a simplification of a previous one by Timm Bäder.