After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742170 - cut/copy/paste binding entries are registered 2x
cut/copy/paste binding entries are registered 2x
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkTextView
3.15.x
Other Linux
: Normal major
: ---
Assigned To: gtk-bugs
gtk-bugs
: 742794 743328 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-01-01 07:16 UTC by Christian Hergert
Modified: 2015-01-22 01:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
textview: remove duplicated binding entries for cut/copy/paste (1.26 KB, patch)
2015-01-01 07:21 UTC, Christian Hergert 		reviewed Details | Review
textview: remove duplicated binding entries for cut/copy/paste (1.21 KB, patch)
2015-01-01 07:22 UTC, Christian Hergert 		none Details | Review
textview: fix duplicated binding entries. use kp variants instead. (1.42 KB, patch)
2015-01-01 07:28 UTC, Christian Hergert 		committed Details | Review

Description Christian Hergert 2015-01-01 07:16:29 UTC 
This means that shift+insert is pasting twice.
Comment 1 Christian Hergert 2015-01-01 07:21:16 UTC 
Created attachment 293538 [details] [review]
textview: remove duplicated binding entries for cut/copy/paste

This fixes the following bug where shift+insert was pasting twice.

https://bugzilla.gnome.org/show_bug.cgi?id=742170

https://bugzilla.gnome.org/show_bug.cgi?id=741170
Comment 2 Christian Hergert 2015-01-01 07:22:02 UTC 
Created attachment 293539 [details] [review]
textview: remove duplicated binding entries for cut/copy/paste

This fixes the following bug where shift+insert was pasting twice.
Comment 3 Garrett Regier 2015-01-01 07:23:38 UTC 
Review of attachment 293538 [details] [review]:

::: gtk/gtktextview.c
@@ -1506,3 @@
-  gtk_binding_entry_add_signal (binding_set, GDK_KEY_Insert, GDK_SHIFT_MASK,
-                                "paste-clipboard", 0);
-

I believe the intention was to use the _KP versions, for instance this is done below with "toggle-overwrite".
Comment 4 Christian Hergert 2015-01-01 07:28:08 UTC 
Created attachment 293540 [details] [review]
textview: fix duplicated binding entries. use kp variants instead.

This appears to have accidentally used the normal keypresses twice instead
of the KP variants. This resulted in shift+insert pasting twice.
Comment 5 Christian Hergert 2015-01-01 07:28:28 UTC 
Yup makes sense, updated.
Comment 6 Christian Hergert 2015-01-01 07:34:34 UTC 
References this commit:

 https://git.gnome.org/browse/gtk+/commit/gtk/gtktextview.c?id=f74a75ae7e256b6cadf38b9aff863176f4de5e79

Going to go ahead and just push this. Feel free to send lashings if necessary.
Comment 7 Garrett Regier 2015-01-12 07:16:47 UTC 
*** Bug 742794 has been marked as a duplicate of this bug. ***
Comment 8 Garrett Regier 2015-01-22 01:18:20 UTC 
*** Bug 743328 has been marked as a duplicate of this bug. ***