After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741910 - xls: markers do not appear in graph
xls: markers do not appear in graph
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Charting
1.12.x
Other Linux
: Normal normal
: ---
Assigned To: Jean Bréfort
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2014-12-23 14:32 UTC by Frédéric Parrenin
Modified: 2015-01-07 14:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
.xls file to reproduce the problem. (12.50 KB, application/vnd.ms-excel)
2014-12-23 14:32 UTC, Frédéric Parrenin 		  Details
Initial patch (4.01 KB, patch)
2014-12-27 14:53 UTC, Jean Bréfort 		none Details | Review

Description Frédéric Parrenin 2014-12-23 14:32:24 UTC 
Created attachment 293261 [details]
.xls file to reproduce the problem.

Steps to reproduce:
- open the attached file in gnumeric
=> in the dD-int-ratios sheet, the graph does not show any marker.
These markers show up when opening the file in XL.

Tested on gnumeric-1.12.14
Comment 1 Morten Welinder 2014-12-23 16:57:14 UTC 
You are asking for an XY plot, but your X data is not numeric.
Comment 2 Frédéric Parrenin 2014-12-23 21:05:58 UTC 
OK you are right, I now see the issue.
The x-data are not numeric.
XL treats them as numbers starting with 0, 1, etc.
Not sure we should do the same, even for the sake of compatibility.
Comment 3 Frédéric Parrenin 2014-12-23 21:22:03 UTC 
Maybe the best thing in this case would be to transform the XY plot to a Line Plot.
Comment 4 Jean Bréfort 2014-12-24 12:25:27 UTC 
Need to be fixed. Both XL and LO show the markers in such graphs.
Comment 5 Jean Bréfort 2014-12-25 19:54:53 UTC 
We might use go_data_is_valid() which is currently not use. The issue is that I don't know what it was introduced for
Comment 6 Jean Bréfort 2014-12-27 14:53:57 UTC 
Created attachment 293375 [details] [review]
Initial patch

Not sure this is safe although I could not get a crash with any plot type I tried (with invalid data).
Comment 7 Jean Bréfort 2015-01-07 14:50:34 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.