GNOME Bugzilla – Bug 741482
Ensure proper SELinux label on /etc/hostname in ifupdown plugin
Last modified: 2015-11-24 11:22:54 UTC
Hello, The ifupdown plugin is not making sure that the /etc/hostname file is properly labeled when changing the hostname on the machine (the ifcfg plugin is doing so). The plugins should probably adjusted to do so
I think it is wrong that settings plugins each try to implement get_hostname()/set_hostname(). Instead there should be one central place, that implements the distro-specific(!) ways to set the hostname. For example, on Fedora, I want to use keyfile only, no ifcfg-rh plugin. But I still want to set the hostname the Fedora way. This is discussed in bug 740409. I think, we should handle both bugs together. I'd depend this bug on the other, and then we close them both together.
OK so apparently the code has now been moved to the nm-settings.c file which provides common functions to all the plugins, I guess this bug can be closed. But the ifcfg-rh plugins still has useless reference to selinux, I guess this can be remvoved too.
(In reply to Laurent Bigonville from comment #2) > OK so apparently the code has now been moved to the nm-settings.c file which > provides common functions to all the plugins, I guess this bug can be closed. > > But the ifcfg-rh plugins still has useless reference to selinux, I guess > this can be remvoved too. Ah right. Dropped now http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=e2b9346d7145a1112a9cb572c0de7ae0c3507bc6 Other then that, this BZ is indeed fixed with bug 740409. Just forgot closing this one.