After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741407 - deinterlace: in query_caps return only supported formats if filter is interlaced
deinterlace: in query_caps return only supported formats if filter is interlaced
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.4.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-11 17:41 UTC by Thibault Saunier
Modified: 2014-12-16 14:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Deinterlace: in query_caps return only supported formats if filter is interlaced (2.24 KB, patch)
2014-12-11 17:41 UTC, Thibault Saunier 		committed Details | Review

Description Thibault Saunier 2014-12-11 17:41:51 UTC 
In some cases the currently set GstVideoInfo is not interlaced, but
upstream caps are interlaced and the info is passed in the filter,
we should take that info into account and make sure that we do not
consider that case as a "pass through" case.
Comment 1 Thibault Saunier 2014-12-11 17:41:54 UTC 
Created attachment 292555 [details] [review]
Deinterlace: in query_caps return only supported formats if filter is interlaced
Comment 2 Sebastian Dröge (slomo) 2014-12-14 11:03:38 UTC 
Review of attachment 292555 [details] [review]:

Looks good except for one little thing. Please push after fixing that :)

::: gst/deinterlace/gstdeinterlace.c
@@ +2151,3 @@
+
+    filter_interlaced = TRUE;
+    for (i = 0; i < gst_caps_get_size (filter); i++) {

Store gst_caps_get_size() in a variable instead of getting it again on every iteration :)
Comment 3 Thibault Saunier 2014-12-14 11:44:13 UTC 
Attachment 292555 [details] pushed as 7694435 - Deinterlace: in query_caps return only supported formats if filter is interlaced
Comment 4 Thibault Saunier 2014-12-14 11:45:05 UTC 
That one should probably be backported.