After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741119 - Pause seems to be broken
Pause seems to be broken
Status: RESOLVED FIXED
Product: gnome-chess
Classification: Applications
Component: General
3.14.x
Other All
: Normal normal
: ---
Assigned To: Sahil Sareen
gnome-chess-maint
Depends on:
Blocks:
 
 
Reported: 2014-12-04 17:01 UTC by Sahil Sareen
Modified: 2014-12-17 00:51 UTC
See Also:
GNOME target: ---
GNOME version: 3.13/3.14

Attachments
Fix the timer pause functionality (2.94 KB, patch)
2014-12-05 17:01 UTC, Sahil Sareen 		none Details | Review
Fix the timer pause functionality + remove timer_expired_cb (855 bytes, patch)
2014-12-10 14:15 UTC, Sahil Sareen 		committed Details | Review

Description Sahil Sareen 2014-12-04 17:01:04 UTC 
Pause the game and resume.
Timer is still on hold.

This assert failure is seen in terminal:

(gnome-chess:11387): GLib-CRITICAL **: g_source_remove: assertion 'tag > 0' failed
Comment 1 Sahil Sareen 2014-12-05 17:01:41 UTC 
Created attachment 292204 [details] [review]
Fix the timer pause functionality

This patch fixes

Bug 721722 - Game ended due to time, but 1s is left on timer
Bug 740988 - Timer is dead in a scenario
Bug 741119 - Pause seems to be broken

I think removing timer_expired_cb() is the right thing to do. But lets push this in for the upcoming release in a couple of weeks and take care of timer_expired_cb a little later.

I've tested this patch about 10-15 times and the functionality seems to work just fine.
Comment 2 Sahil Sareen 2014-12-10 14:15:50 UTC 
Created attachment 292443 [details] [review]
Fix the timer pause functionality + remove timer_expired_cb

This patch doesn't use timer_expired_cb() like the previous patch I submitted.

I've tested 
1. pause - un_pause - pause
2. Resign - Resign
3. Resign - Keep Playing