After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740905 - v4l2: still has 1 include to linux/videodev.h
v4l2: still has 1 include to linux/videodev.h
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other NetBSD
: Normal enhancement
: 1.4.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-29 23:06 UTC by Thomas Klausner
Modified: 2014-11-30 23:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch adding NetBSD support. (1.67 KB, patch)
2014-11-29 23:06 UTC, Thomas Klausner 		rejected Details | Review

Description Thomas Klausner 2014-11-29 23:06:41 UTC 
Created attachment 291807 [details] [review]
Patch adding NetBSD support.

NetBSD has a compatibility layer for Linux' v4l2 video support.
The attached patches (by Jared McNeill, jmcneill@NetBSD.org) include the correct headers to enable it.
Please apply them.
Comment 1 Nicolas Dufresne (ndufresne) 2014-11-30 22:41:47 UTC 
Review of attachment 291807 [details] [review]:

There should no longer be any trace of linux/videodev2.h. It's a bug but this patch is wrong.
Comment 2 Nicolas Dufresne (ndufresne) 2014-11-30 22:52:32 UTC 
Review of attachment 291807 [details] [review]:

::: sys/v4l2/gstv4l2object.c.orig
@@ +339,3 @@
       {V4L2_STD_NTSC_M, "NTSC-M", "NTSC-M"},
       {V4L2_STD_NTSC_M_JP, "NTSC-M-JP", "NTSC-M-JP"},
+#ifdef V4L2_STD_NTSC_M_KR

Also, this is all defined in ext/ so clearly not needed.
Comment 3 Nicolas Dufresne (ndufresne) 2014-11-30 23:09:13 UTC 
1.4:
commit b3e132d2d7a759215cc3b183102b7d0e6f678699
Author: Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Date:   Sun Nov 30 17:52:47 2014 -0500

    v4l2: Remove last include to linux/videodev2.h
    
    We now use and update our internal copy so we no longer have to ifdef
    the entire code for features and defines that where added over the
    years.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=740905

And 1.5
commit cfa5a9d938e586c97be0bce7be779cc95ed4f9e0