After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740859 - sidebar has no border
sidebar has no border
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-11-28 15:06 UTC by Matthias Clasen
Modified: 2016-01-09 08:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
HC: sidebars and vertical toolbars with borders (2.74 KB, patch)
2014-12-02 14:12 UTC, Jakub Steiner 		committed Details | Review

Description Matthias Clasen 2014-11-28 15:06:15 UTC 
As seen on page 3 of widget-factory
Comment 1 Matthias Clasen 2014-11-28 15:06:34 UTC 
same for the vertical toolbar just below
Comment 2 Jakub Steiner 2014-12-02 14:12:15 UTC 
Created attachment 291991 [details] [review]
HC: sidebars and vertical toolbars with borders

- the assumption for vertical toolbar being on the left is perhaps
  a little daring, but...
Comment 3 Jakub Steiner 2014-12-03 10:37:58 UTC 
Attachment 291991 [details] pushed as 88a12fe - HC: sidebars and vertical toolbars with borders
Comment 4 Lapo Calamandrei 2014-12-03 14:53:40 UTC 
This affects adwaita as well and unfortunatelly the proposed solution doesn't really work since when the sidebar overflows the scrollbar gets drawn outside the border since we're using the viewport frame to draw the it.
Comment 5 Lapo Calamandrei 2015-09-08 20:35:43 UTC 
To properly fix this we'd need the GtkStackSidebar to draw a border by itself, or whatever before the viewport, also to avoid making assumptions we'd need left/right positional style classes.
Comment 6 Matthias Clasen 2016-01-09 08:00:39 UTC 
the stacksidebar draws a border in highcontrast now