After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740629 - Add tab completion for the command bar
Add tab completion for the command bar
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-24 14:45 UTC by Alexander Larsson
Modified: 2014-11-24 19:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
command-bar: Make sure any old text is cleared when showing (817 bytes, patch)
2014-11-24 14:45 UTC, Alexander Larsson
committed Details | Review
command: Add CommandProvider::complete signal and gb_command_manager_complete (6.23 KB, patch)
2014-11-24 14:45 UTC, Alexander Larsson
committed Details | Review
command-gaction-provide: Implement action name completion (3.46 KB, patch)
2014-11-24 14:45 UTC, Alexander Larsson
committed Details | Review
command-bar: Implement tab completion (9.38 KB, patch)
2014-11-24 14:45 UTC, Alexander Larsson
committed Details | Review

Description Alexander Larsson 2014-11-24 14:45:14 UTC
This adds initial tab completion in the command bar.
Comment 1 Alexander Larsson 2014-11-24 14:45:40 UTC
Created attachment 291366 [details] [review]
command-bar: Make sure any old text is cleared when showing
Comment 2 Alexander Larsson 2014-11-24 14:45:44 UTC
Created attachment 291367 [details] [review]
command: Add CommandProvider::complete signal and gb_command_manager_complete

This adds the initial scaffolding to get commandline completion in
the command bar. It just lets you fill in possible completions given
some existing text.
Comment 3 Alexander Larsson 2014-11-24 14:45:48 UTC
Created attachment 291368 [details] [review]
command-gaction-provide: Implement action name completion

This completes on the available registered actions.
For now only names are completed on, no parameters.
Comment 4 Alexander Larsson 2014-11-24 14:45:52 UTC
Created attachment 291369 [details] [review]
command-bar: Implement tab completion

When you press tab we expand to the longest common prefix from, and
if no common prefix exists we show the available matches in a list
(multiple tabs scroll in the list).
Comment 5 Christian Hergert 2014-11-24 19:30:47 UTC
Awesome! Thanks for doing this!

Attachment 291366 [details] pushed as 0f5f1c7 - command-bar: Make sure any old text is cleared when showing
Attachment 291367 [details] pushed as db6d5e6 - command: Add CommandProvider::complete signal and gb_command_manager_complete
Attachment 291368 [details] pushed as bb265fc - command-gaction-provide: Implement action name completion
Attachment 291369 [details] pushed as 4b79973 - command-bar: Implement tab completion