After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740556 - videodecoder: don't complain when DTS != PTS on keyframes
videodecoder: don't complain when DTS != PTS on keyframes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 1.4.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-22 20:53 UTC by Matej Knopp
Modified: 2014-11-24 10:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (1.37 KB, patch)
2014-11-22 20:53 UTC, Matej Knopp
committed Details | Review

Description Matej Knopp 2014-11-22 20:53:30 UTC
Created attachment 291276 [details] [review]
Patch

It is a valid thing for streams with b-frames.
Comment 1 Nicolas Dufresne (ndufresne) 2014-11-22 21:11:16 UTC
Review of attachment 291276 [details] [review]:

Right, I should have done that when I fixed x264enc, merging now.
Comment 2 Nicolas Dufresne (ndufresne) 2014-11-22 21:23:50 UTC
Thanks !

commit 9d349d88314968eb27154d5d5a500bf3cbcabf0a
Author: Matej Knopp <matej.knopp@gmail.com>
Date:   Sat Nov 22 21:51:33 2014 +0100

    videoencoder: don't complain about PTS != DTS on keyframes
    
    It is valid for streams with b-frames
    
    https://bugzilla.gnome.org/show_bug.cgi?id=740556
Comment 3 Matej Knopp 2014-11-22 22:13:00 UTC
Actually, I was getting the warning with my own encoders. Your x264fix doesn't seem right though. I've commented on it.
Comment 4 Nicolas Dufresne (ndufresne) 2014-11-22 22:47:26 UTC
See my comment on the other bug ;-P