After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740340 - Need a role for static/generic objects
Need a role for static/generic objects
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: at-spi2-core
unspecified
Other Linux
: Normal normal
: ---
Assigned To: At-spi maintainer(s)
At-spi maintainer(s)
Depends on: 739981
Blocks: 740362 740364
 
 
Reported: 2014-11-18 19:48 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2014-11-19 17:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (3.42 KB, patch)
2014-11-18 19:48 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2014-11-18 19:48:11 UTC
Created attachment 290940 [details] [review]
Proposed patch

+++ This bug was initially created as a clone of Bug #739981 +++

There is currently no AtspiRole type that reflects objects which meet all of the following criteria:

1. Contains accessible information directly (i.e. and not in a child object)
2. Has a role that is known by the implementor
3. Lacks a role with any semantic value for the end user
4. Is not something the user can interact with

If 1 were not the case, then ATSPI_ROLE_PANEL would make sense as its documented definition is "A generic container that is often used to group objects."

If 2 were not the case, then ATSPI_ROLE_UNKNOWN would make sense as its documented definition is "The object contains some Accessible information, but its role is not known."

As for why we cannot address 3 by changing the documentation of ATSPI_ROLE_UNKNOWN (which seems like the easiest way to go): Orca tends to not touch objects with ATSPI_ROLE_UNKNOWN. After all, if the implementor truly has no idea what the thing is, what should the AT do to provide access to it? What interfaces should it check for? What user actions are applicable? Does this accessible object even have a backing widget in the application? All bets are off with "unknown" objects....

If 4 were not the case, odds are that it's a frequently-encountered widget or container for which there is an appropriate AtspiRole.

As for the use case: See http://lists.w3.org/Archives/Public/public-pfwg/2014Nov/0131.html.

I'm attaching a patch which does two things: Adds ATSPI_ROLE_STATIC and updates the documentation for ATSPI_ROLE_TEXT (which is used by Gecko in ways that are inconsistent with the rest of our platform, but given the existing docs you cannot really blame Mozilla). The role and docs match what is proposed for ATK (see bug 739931).
Comment 1 Joanmarie Diggs (IRC: joanie) 2014-11-19 15:28:20 UTC
FYI: The change has now been committed to ATK.

Review for the patch here, please?
Comment 2 Mike Gorse 2014-11-19 16:33:41 UTC
Comment on attachment 290940 [details] [review]
Proposed patch

Looks fine. Thanks.
Comment 3 Joanmarie Diggs (IRC: joanie) 2014-11-19 17:26:02 UTC
Comment on attachment 290940 [details] [review]
Proposed patch

Thanks!

https://git.gnome.org/browse/at-spi2-core/commit/?id=9cbcd0aa