After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740333 - tui: refresh the "nmtui connect" list when connections are added/removed
tui: refresh the "nmtui connect" list when connections are added/removed
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nmtui
unspecified
Other All
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-11-18 17:15 UTC by Dan Winship
Modified: 2014-11-19 15:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tui: refresh the "nmtui connect" list when connections are added/removed (2.85 KB, patch)
2014-11-18 17:15 UTC, Dan Winship 		none Details | Review

Description Dan Winship 2014-11-18 17:15:02 UTC 
fixes beaker test
NetworkManager_Test241_nmtui_general_realtime_refresh_activate_screen_wo_autoconnect.

Though AFAICT, this shouldn't have passed in 0.9.10 either... unless
maybe some bug somewhere else caused a spurious :active-connections or
:devices notification when a connection was added?
Comment 1 Dan Winship 2014-11-18 17:15:03 UTC 
Created attachment 290932 [details] [review]
tui: refresh the "nmtui connect" list when connections are added/removed

We were refreshing the list when the set of available devices changed,
or the set of active connections changed, but not when the set of
available connections changed.
Comment 2 Thomas Haller 2014-11-18 20:47:51 UTC 
LGTM
Comment 3 Jiri Klimes 2014-11-19 15:04:11 UTC 
It looks good to me.