After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740289 - DSI output name missing for screen rotation
DSI output name missing for screen rotation
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-17 22:26 UTC by Jan-Michael Brummer
Modified: 2014-11-18 18:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch adding dsi output name for screen rotation (637 bytes, patch)
2014-11-17 22:26 UTC, Jan-Michael Brummer
needs-work Details | Review
Patch adding dsi output name for screen rotation v2 (1.01 KB, patch)
2014-11-18 18:23 UTC, Jan-Michael Brummer
committed Details | Review

Description Jan-Michael Brummer 2014-11-17 22:26:36 UTC
Created attachment 290883 [details] [review]
Patch adding dsi output name for screen rotation

On the Dell Venue 8 Pro tablet device there is currently no screen rotation possible due to the lack of DSI display information. In order to enable automatic screen rotation libgnome-desktop needs to be extended at _gnome_rr_output_name_is_builtin_display() function to support DSI display names. The attached patch does this job.
Comment 1 Bastien Nocera 2014-11-18 01:39:10 UTC
Review of attachment 290883 [details] [review]:

That looks fine, but could you please git-format the patch? This helps keep the authorship information, and reasoning behind the patch.

Also, could you explain to me how the accelerometer works in that Dell tablet? Is it just an input device with 3 axis, and it "just works" with that gnome-desktop patch added?
Comment 2 Jan-Michael Brummer 2014-11-18 18:23:19 UTC
Created attachment 290939 [details] [review]
 Patch adding dsi output name for screen rotation v2

Attaching the requested git patch file.

The accelerometer is an IIO device and works with the hid_sensor_accel_3d kernel module. But as it does not create an input device on its own we need an adapter to complete this task. For this purpose we are using the iio sensor proxy: https://github.com/hadess/iio-sensor-proxy

After adding the above patch and starting the iio-sensor-proxy the rotation works fine.
Comment 3 Bastien Nocera 2014-11-18 18:37:13 UTC
Committed after cleaning up the commit message, thanks!