After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740228 - video: implement x offset parameter in GstVideoFormatUnpack functions for all formats
video: implement x offset parameter in GstVideoFormatUnpack functions for all...
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-17 00:09 UTC by Tim-Philipp Müller
Modified: 2018-11-03 11:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Tim-Philipp Müller 2014-11-17 00:09:48 UTC 
+++ This bug was initially created as a clone of Bug #739281 +++

Two issues:

a) our GstVideoFormatUnpack functions for the various video formats seem to completely ignore the x parameter.

b) GstVideoFormatPack does not seem to have an x parameter; this is unfortunate, since it means we need to unpack/pack a lot of pixels we don't actually need at all (e.g. when blending pixels of a logo somewhere we'd need to unpack/pack from x=0 to x=logo_xpos+logo_width instead of from x=logo_xpos to x=logo_xpos+logo_width (unless we manually adjust row pointers we pass I guess, which won't work well for complex formats)
Comment 1 Luis de Bethencourt 2014-11-18 17:23:56 UTC 
Vineeth,

Will you have time to work on this bug?
Comment 2 Vineeth 2014-11-19 04:21:38 UTC 
i will try to start working on this from next week, if no one else has started with this...
Comment 3 Tim-Philipp Müller 2014-11-26 11:45:16 UTC 
We can't add an x parameter to the Pack function, so have to compensate for that by adjusting the destination pointers using pstride and subsampling.

Please add unit tests for each format.
Comment 4 Wim Taymans 2014-11-27 12:08:05 UTC 
commit 52d4dd1cb0d3719b7487d5cb0765ecded9028bf4
Author: Wim Taymans <wtaymans@redhat.com>
Date:   Thu Nov 27 13:01:03 2014 +0100

    video-format: handle x offset in unpack
    
    Add support for x offset in almost all unpack methods.
    Fix naming of source and dest pixels.
    Add const to source pixels.
Comment 5 GStreamer system administrator 2018-11-03 11:32:50 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/144.