After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740223 - source_object for GAsyncResult should be nullable
source_object for GAsyncResult should be nullable
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal minor
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-11-16 22:18 UTC by Evan Nemerson
Modified: 2017-10-11 12:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gio: mark the GAsyncResult source_object as nullable (1.36 KB, patch)
2014-11-16 22:18 UTC, Evan Nemerson 		committed Details | Review

Description Evan Nemerson 2014-11-16 22:18:41 UTC 
Created attachment 290816 [details] [review]
gio: mark the GAsyncResult source_object as nullable

g_async_result_get_source_object mentions that the object can be nullable, but the return value us not marked as nullable.  Also, the source_object argument for GAsyncReadyCallback doesn't specifically mention NULL, but it too should be nullable.
Comment 1 Philip Withnall 2017-10-11 12:01:01 UTC 
Review of attachment 290816 [details] [review]:

Looks good, thanks.
Comment 2 Philip Withnall 2017-10-11 12:01:39 UTC 
Attachment 290816 [details] pushed as ca4fe59 - gio: mark the GAsyncResult source_object as nullable