After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740147 - [PATCH] dhcp: wait for an IPv6LL address before starting DHCPv6
[PATCH] dhcp: wait for an IPv6LL address before starting DHCPv6
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: IP and DNS config
unspecified
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
: 726280 (view as bug list)
Depends on:
Blocks: nm-1.0
 
 
Reported: 2014-11-14 22:07 UTC by Dan Williams
Modified: 2014-12-01 11:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-dhcp-wait-for-an-IPv6LL-address-before-starting-DHCP.patch (9.17 KB, patch)
2014-11-14 22:07 UTC, Dan Williams 		reviewed Details | Review

Description Dan Williams 2014-11-14 22:07:49 UTC 
Created attachment 290740 [details] [review]
0001-dhcp-wait-for-an-IPv6LL-address-before-starting-DHCP.patch

For ipv6.method=dhcp NM was not waiting for an IPv6LL address, which
caused the DHCP client to exit early because it had no local address
to bind to.
Comment 1 Dan Winship 2014-11-15 15:07:06 UTC 
Comment on attachment 290740 [details] [review]
0001-dhcp-wait-for-an-IPv6LL-address-before-starting-DHCP.patch

as far as I can tell, it looks right.


>+	if (priv->dhcp6_ip6_config) {
>+		g_object_unref (priv->dhcp6_ip6_config);
>+		priv->dhcp6_ip6_config = NULL;
>+	}

update that to use g_clear_object() while you're there
Comment 2 Pavel Simerda 2014-11-16 12:53:42 UTC 
Does it ensure that we wait for the LL address to become actually ready, i.e. DAD is finished?
Comment 3 Thomas Haller 2014-11-16 16:44:29 UTC 
LGTM


(In reply to comment #2)
> Does it ensure that we wait for the LL address to become actually ready, i.e.
> DAD is finished?

Yes, it ensures that
Comment 4 Dan Williams 2014-11-17 15:52:59 UTC 
Fixed up and pushed.
Comment 5 Dan Winship 2014-11-17 17:08:26 UTC 
*** Bug 726280 has been marked as a duplicate of this bug. ***